From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>
Cc: <linville@tuxdriver.com>, <johannes@sipsolutions.net>,
<linux-wireless@vger.kernel.org>
Subject: Re: [RFC 2/2] cfg80211/nl80211: Enable drivers to implement mac address based ACL
Date: Tue, 4 Sep 2012 09:29:39 +0300 [thread overview]
Message-ID: <50459FD3.2010305@qca.qualcomm.com> (raw)
In-Reply-To: <1346675037-17858-2-git-send-email-vthiagar@qca.qualcomm.com>
On 09/03/2012 03:23 PM, Vasanthakumar Thiagarajan wrote:
> This patch enables drivers to implement mac address based
> access control in AP/P2P GO mode. There is a new flag in
> nl80211_feature_flags (NL80211_FEATURE_MAC_ACL) for drivers
> to advertise this capability. There are two acl policies, white
> and black list, under which an acl list can be configured in the
> driver. Driver has to advertise the maximum number of mac address
> entries in acl list through max_acl_mac_addrs of wiphy.
>
> ACL is enabled/disabled based on attribute NL80211_ATTR_MAC_ACL which
> is passed in start_ap. A list of stations' mac addresses is set
> using NL80211_CMD_SET_MAC_ACL.
I would prefer a bit more documentation how this works from user space
or driver's point of view. I think I can guess how it's supposed to
work, but it would be good to document it explicitly. For example, it
wasn't clear how he driver must function when NL80211_ACL_POLICY_ACCEPT
or DENY is used.
> Driver may have to make sure to clear it's acl list when doing start/stop ap.
s/may/must/?
Kalle
next prev parent reply other threads:[~2012-09-04 6:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-03 12:23 [RFC 1/2] cfg80211: Move the definition of struct mac_address up Vasanthakumar Thiagarajan
2012-09-03 12:23 ` [RFC 2/2] cfg80211/nl80211: Enable drivers to implement mac address based ACL Vasanthakumar Thiagarajan
2012-09-04 6:29 ` Kalle Valo [this message]
2012-09-04 8:45 ` Vasanthakumar Thiagarajan
2012-09-04 8:38 ` Johannes Berg
2012-09-04 9:19 ` Vasanthakumar Thiagarajan
2012-09-04 9:30 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50459FD3.2010305@qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=vthiagar@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).