* [PATCH] rt2x00: fix votage setting for RT3572/RT3592
@ 2012-08-26 22:26 Marc Kleine-Budde
2012-08-27 8:19 ` Ivo Van Doorn
0 siblings, 1 reply; 4+ messages in thread
From: Marc Kleine-Budde @ 2012-08-26 22:26 UTC (permalink / raw)
To: linux-wireless; +Cc: John W. Linville, Marc Kleine-Budde, Gertjan van Wingerde
According to the vendor driver v2.6.0.1, during the rf register init the SRAM
voltage should be increased to 1.35V and after 1ms decreased back to 1.2V. This
patch adds the field setting of LDO_CFG0_LDO_CORE_VLEVEL accordingly.
Cc: Gertjan van Wingerde <gwingerde@gmail.com>
Signed-off-by: Marc Kleine-Budde <mkl@blackshift.org>
---
Hello,
I don't have the hardware to test, just stumbled over this while hacking on the
rt3593.
regards, Marc
drivers/net/wireless/rt2x00/rt2800lib.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
index cb8c2ac..b93516d 100644
--- a/drivers/net/wireless/rt2x00/rt2800lib.c
+++ b/drivers/net/wireless/rt2x00/rt2800lib.c
@@ -4089,6 +4089,7 @@ static int rt2800_init_rfcsr(struct rt2x00_dev *rt2x00dev)
rt2800_register_write(rt2x00dev, LDO_CFG0, reg);
msleep(1);
rt2800_register_read(rt2x00dev, LDO_CFG0, ®);
+ rt2x00_set_field32(®, LDO_CFG0_LDO_CORE_VLEVEL, 0);
rt2x00_set_field32(®, LDO_CFG0_BGSEL, 1);
rt2800_register_write(rt2x00dev, LDO_CFG0, reg);
}
--
1.7.10
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] rt2x00: fix votage setting for RT3572/RT3592
2012-08-26 22:26 [PATCH] rt2x00: fix votage setting for RT3572/RT3592 Marc Kleine-Budde
@ 2012-08-27 8:19 ` Ivo Van Doorn
2012-09-05 8:33 ` Marc Kleine-Budde
0 siblings, 1 reply; 4+ messages in thread
From: Ivo Van Doorn @ 2012-08-27 8:19 UTC (permalink / raw)
To: Marc Kleine-Budde; +Cc: linux-wireless, John W. Linville, Gertjan van Wingerde
On Mon, Aug 27, 2012 at 12:26 AM, Marc Kleine-Budde <mkl@blackshift.org> wrote:
> According to the vendor driver v2.6.0.1, during the rf register init the SRAM
> voltage should be increased to 1.35V and after 1ms decreased back to 1.2V. This
> patch adds the field setting of LDO_CFG0_LDO_CORE_VLEVEL accordingly.
>
> Cc: Gertjan van Wingerde <gwingerde@gmail.com>
> Signed-off-by: Marc Kleine-Budde <mkl@blackshift.org>
Acked-by: Ivo van Doorn <IvDoorn@gmail.com>
> ---
> Hello,
>
> I don't have the hardware to test, just stumbled over this while hacking on the
> rt3593.
>
> regards, Marc
>
> drivers/net/wireless/rt2x00/rt2800lib.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
> index cb8c2ac..b93516d 100644
> --- a/drivers/net/wireless/rt2x00/rt2800lib.c
> +++ b/drivers/net/wireless/rt2x00/rt2800lib.c
> @@ -4089,6 +4089,7 @@ static int rt2800_init_rfcsr(struct rt2x00_dev *rt2x00dev)
> rt2800_register_write(rt2x00dev, LDO_CFG0, reg);
> msleep(1);
> rt2800_register_read(rt2x00dev, LDO_CFG0, ®);
> + rt2x00_set_field32(®, LDO_CFG0_LDO_CORE_VLEVEL, 0);
> rt2x00_set_field32(®, LDO_CFG0_BGSEL, 1);
> rt2800_register_write(rt2x00dev, LDO_CFG0, reg);
> }
> --
> 1.7.10
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] rt2x00: fix votage setting for RT3572/RT3592
2012-08-27 8:19 ` Ivo Van Doorn
@ 2012-09-05 8:33 ` Marc Kleine-Budde
2012-09-05 20:19 ` Gertjan van Wingerde
0 siblings, 1 reply; 4+ messages in thread
From: Marc Kleine-Budde @ 2012-09-05 8:33 UTC (permalink / raw)
To: Ivo Van Doorn; +Cc: linux-wireless, John W. Linville, Gertjan van Wingerde
On 08/27/2012 10:19 AM, Ivo Van Doorn wrote:
> On Mon, Aug 27, 2012 at 12:26 AM, Marc Kleine-Budde <mkl@blackshift.org> wrote:
>> According to the vendor driver v2.6.0.1, during the rf register init the SRAM
>> voltage should be increased to 1.35V and after 1ms decreased back to 1.2V. This
>> patch adds the field setting of LDO_CFG0_LDO_CORE_VLEVEL accordingly.
>>
>> Cc: Gertjan van Wingerde <gwingerde@gmail.com>
>> Signed-off-by: Marc Kleine-Budde <mkl@blackshift.org>
>
> Acked-by: Ivo van Doorn <IvDoorn@gmail.com>
Ping. Is someone taking care of this patch?
Marc
>
>> ---
>> Hello,
>>
>> I don't have the hardware to test, just stumbled over this while hacking on the
>> rt3593.
>>
>> regards, Marc
>>
>> drivers/net/wireless/rt2x00/rt2800lib.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
>> index cb8c2ac..b93516d 100644
>> --- a/drivers/net/wireless/rt2x00/rt2800lib.c
>> +++ b/drivers/net/wireless/rt2x00/rt2800lib.c
>> @@ -4089,6 +4089,7 @@ static int rt2800_init_rfcsr(struct rt2x00_dev *rt2x00dev)
>> rt2800_register_write(rt2x00dev, LDO_CFG0, reg);
>> msleep(1);
>> rt2800_register_read(rt2x00dev, LDO_CFG0, ®);
>> + rt2x00_set_field32(®, LDO_CFG0_LDO_CORE_VLEVEL, 0);
>> rt2x00_set_field32(®, LDO_CFG0_BGSEL, 1);
>> rt2800_register_write(rt2x00dev, LDO_CFG0, reg);
>> }
>> --
>> 1.7.10
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] rt2x00: fix votage setting for RT3572/RT3592
2012-09-05 8:33 ` Marc Kleine-Budde
@ 2012-09-05 20:19 ` Gertjan van Wingerde
0 siblings, 0 replies; 4+ messages in thread
From: Gertjan van Wingerde @ 2012-09-05 20:19 UTC (permalink / raw)
To: Marc Kleine-Budde
Cc: Ivo Van Doorn, linux-wireless@vger.kernel.org, John W. Linville
Marc,
Sent from my iPad
On 5 sep. 2012, at 10:33, Marc Kleine-Budde <mkl@blackshift.org> wrote:
> On 08/27/2012 10:19 AM, Ivo Van Doorn wrote:
>> On Mon, Aug 27, 2012 at 12:26 AM, Marc Kleine-Budde <mkl@blackshift.org> wrote:
>>> According to the vendor driver v2.6.0.1, during the rf register init the SRAM
>>> voltage should be increased to 1.35V and after 1ms decreased back to 1.2V. This
>>> patch adds the field setting of LDO_CFG0_LDO_CORE_VLEVEL accordingly.
>>>
>>> Cc: Gertjan van Wingerde <gwingerde@gmail.com>
>>> Signed-off-by: Marc Kleine-Budde <mkl@blackshift.org>
>>
>> Acked-by: Ivo van Doorn <IvDoorn@gmail.com>
>
> Ping. Is someone taking care of this patch?
>
Normally, John takes these patches after Ivo, Helmut or I have acked them.
However, I believe he was travelling last week, so it takes a bit longer to be applied.
---
Gertjan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-09-05 20:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-26 22:26 [PATCH] rt2x00: fix votage setting for RT3572/RT3592 Marc Kleine-Budde
2012-08-27 8:19 ` Ivo Van Doorn
2012-09-05 8:33 ` Marc Kleine-Budde
2012-09-05 20:19 ` Gertjan van Wingerde
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).