From: "Arend van Spriel" <arend@broadcom.com>
To: "Stanislaw Gruszka" <sgruszka@redhat.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
"Linux Wireless List" <linux-wireless@vger.kernel.org>,
stable <stable@vger.kernel.org>,
"Jonathan Nieder" <jrnieder@gmail.com>,
Camaleón <noelamac@gmail.com>,
"Milan Bouchet-Valat" <nalimilan@club-internet.fr>
Subject: Re: [PATCH 2/2] brcmsmac: rework of mac80211 .flush() callback operation
Date: Wed, 5 Sep 2012 12:37:40 +0200 [thread overview]
Message-ID: <50472B74.5060104@broadcom.com> (raw)
In-Reply-To: <20120905102046.GC2311@redhat.com>
On 09/05/2012 12:20 PM, Stanislaw Gruszka wrote:
> On Wed, Sep 05, 2012 at 11:49:22AM +0200, Arend van Spriel wrote:
>> + ret = wait_event_timeout(wl->tx_flush_wq,
>> + brcms_tx_flush_completed(wl),
>> + msecs_to_jiffies(BRCMS_FLUSH_TIMEOUT));
>> +
>> + ieee80211_wake_queues(hw);
>> + WARN_ON(!ret);
> Any particular reason why this WARN_ON is after ieee80211_wake_queues() ?
>
The wait has a timeout so the warning indicates flush did not complete
as in the old implementation. Maybe a WARN_ON_ONCE() would be better,
but I have not observed the warning yet.
Gr. AvS
next prev parent reply other threads:[~2012-09-05 10:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-05 9:49 [PATCH 0/2] brcmsmac: fix for regulatory rules and flush callback Arend van Spriel
2012-09-05 9:49 ` [PATCH 1/2] brcmsmac: fix mismatch in number of custom regulatory rules Arend van Spriel
2012-09-05 12:40 ` Seth Forshee
2012-09-05 9:49 ` [PATCH 2/2] brcmsmac: rework of mac80211 .flush() callback operation Arend van Spriel
2012-09-05 10:20 ` Stanislaw Gruszka
2012-09-05 10:37 ` Arend van Spriel [this message]
2012-09-05 11:49 ` Stanislaw Gruszka
2012-09-05 16:57 ` Seth Forshee
2012-09-05 17:33 ` Brad Figg
2012-09-05 19:21 ` Arend van Spriel
2012-09-05 19:33 ` Seth Forshee
2012-09-05 20:00 ` Arend van Spriel
2012-09-05 20:07 ` Seth Forshee
2012-09-05 19:46 ` Brad Figg
2012-09-05 19:48 ` Arend van Spriel
2012-09-10 13:22 ` [PATCH 0/2] brcmsmac: fix for regulatory rules and flush callback Arend van Spriel
2012-09-10 18:33 ` John W. Linville
2012-09-10 20:41 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50472B74.5060104@broadcom.com \
--to=arend@broadcom.com \
--cc=jrnieder@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=nalimilan@club-internet.fr \
--cc=noelamac@gmail.com \
--cc=sgruszka@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).