From: "Arend van Spriel" <arend@broadcom.com>
To: "Johannes Berg" <johannes@sipsolutions.net>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"John W. Linville" <linville@tuxdriver.com>
Subject: Re: mac80211 flush callback
Date: Wed, 5 Sep 2012 18:27:10 +0200 [thread overview]
Message-ID: <50477D5E.2040003@broadcom.com> (raw)
In-Reply-To: <1346853217.4364.15.camel@jlt4.sipsolutions.net>
On 09/05/2012 03:53 PM, Johannes Berg wrote:
> Hi Arend,
>
>> I ma currently looking into a long standing issue with flush callback in
>> brcmsmac. After some debugging I found out that mac80211 keeps pushing
>> packets to brcmsmac during the flush. Is that correct? Should brcmsmac
>> (or any other driver) stop the mac80211 queues during the flush? My
>> assumption was that mac80211 would not do transmits during the flush,
>> but it probably comes from another worker thread.
>
> Hmm, good question, this area isn't quite fully worked out yet I
> think ... probably better to stop queues yourself for now, although I
> guess mac80211 should really take care to do it ...
>
Thanks, Johannes
I did look at some other driver and it seems they grab a mutex in the
flush that is (probably?) also grabbed in the tx path thus blocking it.
For brcmsmac I submitted a patch to explicitly stop the queues in the flush.
Gr. AvS
next prev parent reply other threads:[~2012-09-05 16:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-29 11:32 mac80211 flush callback Arend van Spriel
2012-09-05 13:53 ` Johannes Berg
2012-09-05 16:27 ` Arend van Spriel [this message]
2012-09-05 16:34 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50477D5E.2040003@broadcom.com \
--to=arend@broadcom.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).