From: Brad Figg <brad.figg@canonical.com>
To: Arend van Spriel <arend@broadcom.com>
Cc: "Seth Forshee" <seth.forshee@canonical.com>,
"John W. Linville" <linville@tuxdriver.com>,
"Linux Wireless List" <linux-wireless@vger.kernel.org>,
stable <stable@vger.kernel.org>,
"Jonathan Nieder" <jrnieder@gmail.com>,
"Stanislaw Gruszka" <sgruszka@redhat.com>,
Camaleón <noelamac@gmail.com>,
"Milan Bouchet-Valat" <nalimilan@club-internet.fr>
Subject: Re: [PATCH 2/2] brcmsmac: rework of mac80211 .flush() callback operation
Date: Wed, 05 Sep 2012 12:46:29 -0700 [thread overview]
Message-ID: <5047AC15.8060207@canonical.com> (raw)
In-Reply-To: <5047A624.7090105@broadcom.com>
On 09/05/2012 12:21 PM, Arend van Spriel wrote:
> On 09/05/2012 07:33 PM, Brad Figg wrote:
>> On 09/05/2012 09:57 AM, Seth Forshee wrote:
>>> On Wed, Sep 05, 2012 at 11:49:22AM +0200, Arend van Spriel wrote:
>>>> This patch addresses a long standing issue of the driver with the
>>>> mac80211 .flush() callback. Since implementing the .flush() callback
>>>> a number of issues have been fixed, but a WARN_ON_ONCE() was still
>>>> triggered because the flush takes too much time. The flush now
>>>> makes use of a waitqueue and still has a timeout on which a warning
>>>> is given.
>>>
>>> Brad Figg and I have been testing this patch with a 3.5 kernel. With the
>>> patch we're both still seeing the warning from brcms_ops_flush(), and
>>> Brad has also seen the "No where to go" message in
>>> brcms_c_prec_enq_head(). But the connection continues to work when this
>>> happens, whereas previously we had to reconnect, so this is definitely
>>> an improvement.
>>>
>>> Seth
>>>
>>
>> Arend,
>>
>> Though the driver is definitely better, it is still struggling quite a
>> bit as can be seen in the iperf output found at:
>> http://pastebin.ubuntu.com/1187578/
>>
>
> Thanks, Brad
>
> I was focusing on the warning in the flush callback. I actually could not reproduce the "nowhere to go" message under my ubuntu test laptop.
>
> The root cause of your problem seems the "nowhere to go". Basically, all packet queues in the driver have reached their limit. In that case packets are simply dropped.
>
> Could you provide following info:
> * cpu info
> * wireless device id
> * scan data of your AP
> * kernel configuration
>
> If I can download the kernel debian package of your 3.5 kernel from somewhere that would be great.
>
> Gr. AvS
>
Arend,
I just filed https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1046507
which should contain all this information.
If there is _anything_ more I can provide to you or test for you do not
hesitate to ask.
Brad
--
Brad Figg brad.figg@canonical.com http://www.canonical.com
next prev parent reply other threads:[~2012-09-05 19:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-05 9:49 [PATCH 0/2] brcmsmac: fix for regulatory rules and flush callback Arend van Spriel
2012-09-05 9:49 ` [PATCH 1/2] brcmsmac: fix mismatch in number of custom regulatory rules Arend van Spriel
2012-09-05 12:40 ` Seth Forshee
2012-09-05 9:49 ` [PATCH 2/2] brcmsmac: rework of mac80211 .flush() callback operation Arend van Spriel
2012-09-05 10:20 ` Stanislaw Gruszka
2012-09-05 10:37 ` Arend van Spriel
2012-09-05 11:49 ` Stanislaw Gruszka
2012-09-05 16:57 ` Seth Forshee
2012-09-05 17:33 ` Brad Figg
2012-09-05 19:21 ` Arend van Spriel
2012-09-05 19:33 ` Seth Forshee
2012-09-05 20:00 ` Arend van Spriel
2012-09-05 20:07 ` Seth Forshee
2012-09-05 19:46 ` Brad Figg [this message]
2012-09-05 19:48 ` Arend van Spriel
2012-09-10 13:22 ` [PATCH 0/2] brcmsmac: fix for regulatory rules and flush callback Arend van Spriel
2012-09-10 18:33 ` John W. Linville
2012-09-10 20:41 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5047AC15.8060207@canonical.com \
--to=brad.figg@canonical.com \
--cc=arend@broadcom.com \
--cc=jrnieder@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=nalimilan@club-internet.fr \
--cc=noelamac@gmail.com \
--cc=seth.forshee@canonical.com \
--cc=sgruszka@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).