From: Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: <linville@tuxdriver.com>, <linux-wireless@vger.kernel.org>
Subject: Re: [RFC V2 2/2] cfg80211/nl80211: Enable drivers to implement mac address based ACL
Date: Thu, 6 Sep 2012 15:39:20 +0530 [thread overview]
Message-ID: <50487650.3050303@qca.qualcomm.com> (raw)
In-Reply-To: <1346852578.4364.13.camel@jlt4.sipsolutions.net>
On Wednesday 05 September 2012 07:12 PM, Johannes Berg wrote:
> On Wed, 2012-09-05 at 11:18 +0530, Vasanthakumar Thiagarajan wrote:
>
>> + * @NL80211_ATTR_MAC_ACL_MAX: u16 attribute to advertise the maximum
>> + * number of mac addresses that a device can support for MAC
>> + * access control.
>
> Why not use u32? I know we won't use more than u16 most likely, but u32
> takes just as much space in netlink messages ...
Sure.
>
>
>> Drivers
>> + * which advertise the support for mac address based access control have to
>> + * implement this callback.
>
> You might consider checking this in register_wiphy?
Right, thanks!.
>
>
> So about the race condition ... shouldn't the initial MAC list be given
> in the start_ap() call, so that the AP can start up with a proper ACL
> already in place, rather than starting up& then modifying later?
Ok. So the ap will start with the initial mac list and the list
can also be changed dynamically?. I'm fine with this.
Vasanth
next prev parent reply other threads:[~2012-09-06 10:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-05 5:48 [RFC V2 1/2] cfg80211: Move the definition of struct mac_address up Vasanthakumar Thiagarajan
2012-09-05 5:48 ` [RFC V2 2/2] cfg80211/nl80211: Enable drivers to implement mac address based ACL Vasanthakumar Thiagarajan
2012-09-05 13:42 ` Johannes Berg
2012-09-06 10:09 ` Vasanthakumar Thiagarajan [this message]
2012-09-06 10:11 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50487650.3050303@qca.qualcomm.com \
--to=vthiagar@qca.qualcomm.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).