From: Rymarkiewicz Waldemar <waldemar.rymarkiewicz@tieto.com>
To: Eric Lapuyade <eric.lapuyade@linux.intel.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-nfc@lists.01.org" <linux-nfc@lists.01.org>,
"sameo@linux.intel.com" <sameo@linux.intel.com>,
"eric.lapuyade@intel.com" <eric.lapuyade@intel.com>
Subject: Re: [linux-nfc] [PATCH 2/2] NFC: Correct outgoing frame before requeueing
Date: Fri, 7 Sep 2012 08:38:02 +0200 [thread overview]
Message-ID: <5049964A.6020808@tieto.com> (raw)
In-Reply-To: <5048CCA7.4010604@linux.intel.com>
Hi Eric,
> This patch would work for PN544, but it makes the assumption that the
> driver will always insert/append exactly client_headroom/client_tailroom
> bytes when xmit is called. This is not specified nor enforced so it may
> be a little dangerous.
Do you mean that the driver can request client_head/tailroom which is a
maximum it can use, but it does not mean that all space will be used in
in each frame e.g. due to optional fields? That's the only situation I
can imagine now.
BTW I see the headroom for pn544 is 2 but it make use of 1 byte (len).
Is that correct?
Thanks,
/Waldek
next prev parent reply other threads:[~2012-09-07 6:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-06 10:22 [PATCH 1/2] NFC: Remove crc generation from shdlc layer Waldemar Rymarkiewicz
2012-09-06 10:22 ` [PATCH 2/2] NFC: Correct outgoing frame before requeueing Waldemar Rymarkiewicz
2012-09-06 16:17 ` [linux-nfc] " Eric Lapuyade
2012-09-07 6:38 ` Rymarkiewicz Waldemar [this message]
2012-09-07 7:43 ` Eric Lapuyade
2012-09-07 8:08 ` Rymarkiewicz Waldemar
2012-09-06 16:02 ` [linux-nfc] [PATCH 1/2] NFC: Remove crc generation from shdlc layer Eric Lapuyade
2012-09-07 8:08 ` Eric Lapuyade
2012-09-07 8:11 ` Rymarkiewicz Waldemar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5049964A.6020808@tieto.com \
--to=waldemar.rymarkiewicz@tieto.com \
--cc=eric.lapuyade@intel.com \
--cc=eric.lapuyade@linux.intel.com \
--cc=linux-nfc@lists.01.org \
--cc=linux-wireless@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).