From: Pandiyarajan <c_ppitch@qca.qualcomm.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: <linville@tuxdriver.com>, <linux-wireless@vger.kernel.org>
Subject: Re: [RFC] cfg80211/nl80211: Notify connection request failure in AP mode
Date: Mon, 10 Sep 2012 20:42:27 +0530 [thread overview]
Message-ID: <504E035B.7050106@qca.qualcomm.com> (raw)
In-Reply-To: <1347276502.4272.22.camel@jlt4.sipsolutions.net>
Hi Johannes,
On Monday 10 September 2012 04:58 PM, Johannes Berg wrote:
> On Mon, 2012-09-10 at 16:23 +0530, Pandiyarajan Pitchaimuthu wrote:
>> In AP mode, when a station requests connection to an AP and if the
>> request is failed for particular reason, userspace is notified about the
>> failure through NL80211_CMD_CONN_FAILED command. Reason for the failure
>> is sent through the attribute NL80211_ATTR_CONN_FAILED_REASON.
> Why would userspace care?
It would be useful to inform the userspace that the driver/firmware's
limitation of maintaining the maximum number of connected clients is
reached.
Without this the user may not be clear about why another client cannot
be added.
Also, further enhancements/decisions can be made based on this event.
>> +/* AP mode - sta's connection request failed reasons */
>> +enum nl80211_connect_failed_reason {
>> + NL80211_CONN_FAIL_MAX_CLIENTS = 1,
>> + NL80211_CONN_FAIL_BLOCKED_CLIENT = 2,
>> +};
> Why number explicitly?
Thanks. Will change it to have the default value.
>> + * Whenever a station tries to connect to an AP and if the station
>> + * could not connect to the AP for some reason, this function is called.
> It's not really "for some reason", it's "because the AP rejected it for
> some reason"... You're not handling other cases anyway.
>
> johannes
>
Sure. Will change the comment.
Pandiyarajan.P
prev parent reply other threads:[~2012-09-10 15:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-10 10:53 [RFC] cfg80211/nl80211: Notify connection request failure in AP mode Pandiyarajan Pitchaimuthu
2012-09-10 11:28 ` Johannes Berg
2012-09-10 15:12 ` Pandiyarajan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=504E035B.7050106@qca.qualcomm.com \
--to=c_ppitch@qca.qualcomm.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).