From: Larry Finger <Larry.Finger@lwfinger.net>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Marc MERLIN <marc@merlins.org>,
wey-yi.w.guy@intel.com, ilw@linux.intel.com,
linux-wireless@vger.kernel.org, netdev@ger.kernel.org
Subject: Re: kernel 3.5.2/amd64: iwlwifi 0000:03:00.0: failed to allocate pci memory
Date: Mon, 10 Sep 2012 10:12:59 -0500 [thread overview]
Message-ID: <504E037B.9030801@lwfinger.net> (raw)
In-Reply-To: <1347272641.4272.1.camel@jlt4.sipsolutions.net>
On 09/10/2012 05:24 AM, Johannes Berg wrote:
> On Sat, 2012-09-08 at 20:57 +0200, Johannes Berg wrote:
>
>>> [856806.497959] [<ffffffff810cf54c>] warn_alloc_failed+0x117/0x12c
>>> [856806.497963] [<ffffffff810d23af>] __alloc_pages_nodemask+0x6e3/0x792
>>> [856806.497969] [<ffffffff812b7f41>] ? pfn_to_dma_pte+0x116/0x15e
>>> [856806.497976] [<ffffffff810ff58b>] alloc_pages_current+0xcd/0xee
>>> [856806.497979] [<ffffffff810cecca>] __get_free_pages+0x9/0x45
>>> [856806.497982] [<ffffffff812ba67d>] intel_alloc_coherent+0x84/0xe7
>>> [856806.497986] [<ffffffff81085cf8>] ? arch_local_irq_save+0x15/0x1b
>>> [856806.497999] [<ffffffffa0b84afc>] iwl_ucode_callback+0xa49/0xc0d [iwlwifi]
>>
>> Yes, unfortunately we need a whole bunch of contiguous memory to load
>> the firmware.
>>
>>> Any ideas?
>>
>> Nothing we can do from the driver side, I'm afraid.
>
> Turns out I was wrong. Here's a patch you can test. Note that we still
> need a lot of DMA-coherent memory for other things, but at least for the
> firmware image we don't.
>
> http://p.sipsolutions.net/11ea33b376a5bac5.txt
That patch looks like a good way to solve the problem; however, some
architectures need an explicit "#include <linux/vmalloc.h>" somewhere in the
headers, even though x86 does not, and I did not see it in the patch. I didn't
do a lot of checking, but grep did not find one in the existing code.
Larry
next prev parent reply other threads:[~2012-09-10 15:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120908161038.GF3347@merlins.org>
[not found] ` <1347122927.1234.849.camel@edumazet-glaptop>
2012-09-04 0:30 ` kernel 3.5.2/amd64: iwlwifi 0000:03:00.0: failed to allocate pci memory Marc MERLIN
2012-09-08 17:01 ` Marc MERLIN
2012-09-08 18:57 ` Johannes Berg
2012-09-10 10:24 ` Johannes Berg
2012-09-10 15:12 ` Larry Finger [this message]
2012-09-10 15:44 ` Johannes Berg
2012-09-10 15:34 ` Marc MERLIN
[not found] ` <20120910154402.GF5053@merlins.org>
[not found] ` <1347292023.4272.28.camel@jlt4.sipsolutions.net>
2012-09-13 4:52 ` Marc MERLIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=504E037B.9030801@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=ilw@linux.intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=marc@merlins.org \
--cc=netdev@ger.kernel.org \
--cc=wey-yi.w.guy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).