From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: <linux-wireless@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
ath6kl-devel <ath6kl-devel@qualcomm.com>
Subject: Re: [PATCH] Fix uninitialized variable in ath6kl ath6kl_sdio_enable_scatter
Date: Fri, 21 Sep 2012 19:41:07 +0300 [thread overview]
Message-ID: <505C98A3.9060109@qca.qualcomm.com> (raw)
In-Reply-To: <20120903201536.GA16230@one.firstfloor.org>
On 09/03/2012 11:15 PM, Andi Kleen wrote:
> gcc 4.8 warns
>
> /backup/lsrc/git/linux-lto-2.6/drivers/net/wireless/ath/ath6kl/sdio.c:
> In function 'ath6kl_sdio_enable_scatter':
> /backup/lsrc/git/linux-lto-2.6/drivers/net/wireless/ath/ath6kl/sdio.c:748:16:
> warning: 'ret' may be used uninitialized in this function
> [-Wmaybe-uninitialized]
> if (virt_scat || ret) {
> ^
>
> The variable can indeed be uninitialized when the previous if branch is
> skipped. I just set it to zero for now. I'm not fully sure the fix is
> correct, maybe the || should be an && ?
>From a quick look || should be correct, but of course I might be missing
something. I think your patch is correct way to fix this.
Thanks, applied to ath6kl.git. I just added "ath6kl:" prefix to the title.
Kalle
prev parent reply other threads:[~2012-09-21 16:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-03 20:15 [PATCH] Fix uninitialized variable in ath6kl ath6kl_sdio_enable_scatter Andi Kleen
2012-09-21 16:41 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=505C98A3.9060109@qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=andi@firstfloor.org \
--cc=ath6kl-devel@qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).