From: Mahesh Palivela <maheshp@posedge.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linville@tuxdriver.com" <linville@tuxdriver.com>
Subject: Re: [PATCH v2] mac80211: VHT peer STA caps
Date: Tue, 25 Sep 2012 10:56:33 +0530 [thread overview]
Message-ID: <50614089.6020105@posedge.com> (raw)
In-Reply-To: <1348477154.10257.2.camel@jlt4.sipsolutions.net>
On 09/24/2012 02:29 PM, Johannes Berg wrote:
> On Mon, 2012-09-24 at 03:57 +0000, Mahesh Palivela wrote:
>> From: Mahesh Palivela <maheshp@posedge.com>
>>
>> To save peer STA VHT capabilities in mac80211.
>>
>> Signed-off-by: Mahesh Palivela <maheshp@posedge.com>
>> ---
>> Taken care of Johannes comments in patch v1
>> + vht_cap->cap = le16_to_cpu(vht_cap_ie->vht_cap_info);
>> +
>
> Well I think it'd be better to actually restrict/copy/update the feature
> bits correctly, this would simplify drivers.
I am not sure on what bits to be masked. wanted to keep it as future item.
Anyways I attempted few bits below. Let me know if they are ok...
vht_cap->cap = le16_to_cpu(vht_cap_ie->vht_cap_info) &
(sband->ht_cap.cap |
~(IEEE80211_VHT_CAP_RXLDPC |
IEEE80211_VHT_CAP_SU_BEAMFORMER_CAPABLE |
IEEE80211_VHT_CAP_MU_BEAMFORMER_CAPABLE |
IEEE80211_VHT_CAP_HTC_VHT));
>
> johannes
>
next prev parent reply other threads:[~2012-09-25 5:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-24 3:57 [PATCH v2] mac80211: VHT peer STA caps Mahesh Palivela
2012-09-24 8:59 ` Johannes Berg
2012-09-25 5:26 ` Mahesh Palivela [this message]
2012-09-25 7:25 ` Johannes Berg
2012-09-25 9:49 ` Mahesh Palivela
2012-09-25 14:09 ` Johannes Berg
2012-09-26 3:15 ` Mahesh Palivela
2012-09-26 11:53 ` Johannes Berg
2012-09-26 17:22 ` Mahesh Palivela
2012-09-26 17:53 ` Johannes Berg
2012-09-27 3:23 ` Mahesh Palivela
2012-09-27 6:24 ` Johannes Berg
2012-09-27 6:34 ` Mahesh Palivela
2012-09-27 7:01 ` Johannes Berg
2012-09-27 7:21 ` Mahesh Palivela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50614089.6020105@posedge.com \
--to=maheshp@posedge.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).