From: Mahesh Palivela <maheshp@posedge.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linville@tuxdriver.com" <linville@tuxdriver.com>
Subject: Re: [PATCH v2] mac80211: VHT peer STA caps
Date: Tue, 25 Sep 2012 15:19:32 +0530 [thread overview]
Message-ID: <50617E2C.6050000@posedge.com> (raw)
In-Reply-To: <1348557902.10041.17.camel@jlt4.sipsolutions.net>
On 09/25/2012 12:55 PM, Johannes Berg wrote:
>>
>> vht_cap->cap = le16_to_cpu(vht_cap_ie->vht_cap_info) &
>> (sband->ht_cap.cap |
>
> err, vht_cap
Sorry, I meant vht_cap only. Typo..
>
>> ~(IEEE80211_VHT_CAP_RXLDPC |
>> IEEE80211_VHT_CAP_SU_BEAMFORMER_CAPABLE |
>> IEEE80211_VHT_CAP_MU_BEAMFORMER_CAPABLE |
>> IEEE80211_VHT_CAP_HTC_VHT));
>
> I don't think that can be right. It seems to me it should be something
> like
>
> cap = cap_info & sband->vht_cap.cap &
> (MAX_MPDU_LENGTH_... |
> SHORT_GI_... | HTC_VHT | ... ? )
>
> if (cap_info & SU_BEAMFORMEE_CAPABLE &&
> sband->vht_cap.cap & SU_BEAMFORMER_CAPABLE)
> cap |= SU_BEAMFORMEE_CAPABLE;
>
> etc.?
>
> OTOH, this would only matter to drivers that actually support all these
> features, and those drivers could take care of not enabling the features
> if their hardware doesn't support them. However, think of a driver that
> is for different hardware, some that supports beamforming and some that
> doesn't. Then if we mask out the beamforming capability of a station if
> it's not locally supported, that driver could be simpler? Then again, if
> we don't the driver just has to check if the hardware supports it, which
> seems reasonable as well.
>
> Do you understand the issue?
>
why should we mask out remote STA caps bits. Our local hw caps are in
sband->sta.vht_caps. remote caps sta_info->sta.vht_caps. In what way
drivers are connected with remote STA vht caps bits.
> So maybe if you document it right, your original v2 patch is sufficient.
> Convince me :)
>
> johannes
>
next prev parent reply other threads:[~2012-09-25 9:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-24 3:57 [PATCH v2] mac80211: VHT peer STA caps Mahesh Palivela
2012-09-24 8:59 ` Johannes Berg
2012-09-25 5:26 ` Mahesh Palivela
2012-09-25 7:25 ` Johannes Berg
2012-09-25 9:49 ` Mahesh Palivela [this message]
2012-09-25 14:09 ` Johannes Berg
2012-09-26 3:15 ` Mahesh Palivela
2012-09-26 11:53 ` Johannes Berg
2012-09-26 17:22 ` Mahesh Palivela
2012-09-26 17:53 ` Johannes Berg
2012-09-27 3:23 ` Mahesh Palivela
2012-09-27 6:24 ` Johannes Berg
2012-09-27 6:34 ` Mahesh Palivela
2012-09-27 7:01 ` Johannes Berg
2012-09-27 7:21 ` Mahesh Palivela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50617E2C.6050000@posedge.com \
--to=maheshp@posedge.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).