From: Larry Finger <Larry.Finger@lwfinger.net>
To: Joe Perches <joe@perches.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Chaoming Li <chaoming_li@realsil.com.cn>,
"David S. Miller" <davem@davemloft.net>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] rtlwifi: use %*ph[C] to dump small buffers
Date: Thu, 27 Sep 2012 10:16:59 -0500 [thread overview]
Message-ID: <50646DEB.8020400@lwfinger.net> (raw)
In-Reply-To: <1348677946.15175.8.camel@joe-AO722>
On 09/26/2012 11:45 AM, Joe Perches wrote:
>
> rate_mask uses:
>
> u32 ratr_bitmap = (u32) mac->basic_rates;
> ...
> u8 rate_mask[5];
> ...
> [sets ratr_bitmap as u32]
> ...
> *(u32 *)&rate_mask = ((ratr_bitmap & 0x0fffffff) |
> ratr_index << 28);
> ...
> rtl92c_fill_h2c_cmd(hw, H2C_RA_MASK, 5, rate_mask);
>
> Looks like a possible endian misuse to me.
Joe,
I had to track the flow through two more routines, but I think your analysis is
correct. The only BE platform I have does not have any PCIe hardware, thus I can
only test the USB version. It does not show a major problem, but this one with
the rate masks would be subtle.
Thanks,
Larry
next prev parent reply other threads:[~2012-09-27 15:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-26 13:57 [PATCH] rtlwifi: use %*ph[C] to dump small buffers Andy Shevchenko
2012-09-26 16:45 ` Joe Perches
2012-09-27 15:16 ` Larry Finger [this message]
2012-09-27 22:28 ` Larry Finger
2012-09-28 3:13 ` Joe Perches
2012-09-28 9:04 ` David Laight
2012-09-28 16:41 ` Larry Finger
2012-09-28 17:24 ` Joe Perches
2012-09-27 15:10 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50646DEB.8020400@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=andriy.shevchenko@linux.intel.com \
--cc=chaoming_li@realsil.com.cn \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).