From: Mahesh Palivela <maheshp@posedge.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v3] mac80211: VHT peer STA caps
Date: Mon, 1 Oct 2012 20:11:01 +0530 [thread overview]
Message-ID: <5069AB7D.7060203@posedge.com> (raw)
In-Reply-To: <1349090417.10330.27.camel@jlt4.sipsolutions.net>
On 10/1/2012 4:50 PM, Johannes Berg wrote:
> Hm, seems I missed this before:
>
>> --- a/include/net/cfg80211.h
>> +++ b/include/net/cfg80211.h
>> @@ -498,6 +498,7 @@ enum station_parameters_apply_mask {
>> * @plink_action: plink action to take
>> * @plink_state: set the peer link state for a station
>> * @ht_capa: HT capabilities of station
>> + * @vht_capa: VHT capabilities of station
>> * @uapsd_queues: bitmap of queues configured for uapsd. same format
>> * as the AC bitmap in the QoS info field
>> * @max_sp: max Service Period. same format as the MAX_SP in the
>> @@ -517,6 +518,7 @@ struct station_parameters {
>> u8 plink_action;
>> u8 plink_state;
>> struct ieee80211_ht_cap *ht_capa;
>> + struct ieee80211_vht_cap *vht_capa;
>
>
> I don't think this should be part of this particular patch? Shouldn't
> there be a cfg80211/nl80211 patch to allow hostapd to set this
> information when adding a station, like for HT, and then that patch
> introduces this struct member?
I agree. I will give that as separate patch.
>
>> + * @vht_cap: VHT capabilities of this STA; Not restricting any capabilities
>> + * of remote STA. Taking as is.
>
> Thanks :)
>
>
>> - 2 + sizeof(struct ieee80211_vht_capabilities) + /* VHT */
>> + 2 + sizeof(struct ieee80211_vht_cap) + /* VHT */
>
> Maybe all this renaming (and the ieee80211.h change) could be a separate
> patch? Then this would be easier to read overall I think.
>
Ok. will do.
>
>> +#include <linux/ieee80211.h>
>> +#include <linux/export.h>
>
> export.h isn't needed here (yet)
sure, will remove it.
>
> johannes
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Thanks,
Mahesh
prev parent reply other threads:[~2012-10-01 14:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-27 7:27 [PATCH v3] mac80211: VHT peer STA caps Mahesh Palivela
2012-10-01 11:20 ` Johannes Berg
2012-10-01 14:41 ` Mahesh Palivela [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5069AB7D.7060203@posedge.com \
--to=maheshp@posedge.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).