From: "Arend van Spriel" <arend@broadcom.com>
To: "Dan Carpenter" <dan.carpenter@oracle.com>
Cc: "Brett Rudley" <brudley@broadcom.com>,
"Roland Vossen" <rvossen@broadcom.com>,
"Franky (Zhenhui) Lin" <frankyl@broadcom.com>,
"Kan Yan" <kanyan@broadcom.com>,
"John W. Linville" <linville@tuxdriver.com>,
"Hante Meuleman" <meuleman@broadcom.com>,
"Pieter-Paul Giesberts" <pieterpg@broadcom.com>,
linux-wireless@vger.kernel.org, brcm80211-dev-list@broadcom.com,
kernel-janitors@vger.kernel.org
Subject: Re: [patch 3/3] brcmfmac: Using zero instead of NULL
Date: Thu, 4 Oct 2012 18:27:48 +0200 [thread overview]
Message-ID: <506DB904.9000002@broadcom.com> (raw)
In-Reply-To: <20121003060713.GC3802@elgon.mountain>
On 10/03/2012 08:07 AM, Dan Carpenter wrote:
> Sparse complains that we use zero instead of NULL here. In fact, the
> initialization is wrong and should be removed. Doing these kinds of
> bogus initializations means that GCC can't detect unitialized variables
> and leads to bugs.
We already had it fixed internally, but your change is more sensible. I
had it reviewed internally and plan to send it to John for 3.8 (ie.
wireless-next after merge window). Let me know if that is ok with you.
Gr. AvS
next prev parent reply other threads:[~2012-10-04 16:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-03 6:07 [patch 3/3] brcmfmac: Using zero instead of NULL Dan Carpenter
2012-10-04 16:27 ` Arend van Spriel [this message]
2012-10-04 18:43 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=506DB904.9000002@broadcom.com \
--to=arend@broadcom.com \
--cc=brcm80211-dev-list@broadcom.com \
--cc=brudley@broadcom.com \
--cc=dan.carpenter@oracle.com \
--cc=frankyl@broadcom.com \
--cc=kanyan@broadcom.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=meuleman@broadcom.com \
--cc=pieterpg@broadcom.com \
--cc=rvossen@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).