From: "Arend van Spriel" <arend@broadcom.com>
To: "Sven Eckelmann" <sven@narfation.org>
Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com,
mcgrof@qca.qualcomm.com,
"Simon Wunderlich" <siwu@hrz.tu-chemnitz.de>
Subject: Re: [PATCHv2] ath_hw: Use common REG_WRITE parameter order
Date: Fri, 5 Oct 2012 18:29:13 +0200 [thread overview]
Message-ID: <506F0AD9.70200@broadcom.com> (raw)
In-Reply-To: <1349372595-19966-1-git-send-email-sven@narfation.org>
On 10/04/2012 07:43 PM, Sven Eckelmann wrote:
> All defines for REG_WRITE in Atheros wireless drivers use the order "ah",
> "register" and "value". hw.c is the only file using the order "ah", "value" and
> "register".
>
> drivers/net/wireless/ath/ath9k/hw.h:#define REG_WRITE(_ah, _reg, _val) \
Just to bad you did not catch the next line in hw.h.
Gr. AvS
> drivers/net/wireless/ath/key.c:#define REG_WRITE(_ah, _reg, _val) (common->ops->write)(_ah, _val, _reg)
>
> This inconsistent definition can easily lead to implementation errors. The
> modification doesn't change the behavior of the driver or the generated code.
>
> Signed-off-by: Sven Eckelmann <sven@narfation.org>
> Signed-off-by: Simon Wunderlich <siwu@hrz.tu-chemnitz.de>
> ---
> Changed commit message
>
> drivers/net/wireless/ath/hw.c | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
next prev parent reply other threads:[~2012-10-05 16:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-04 16:05 [PATCH] ath_hw: Use common REG_WRITE parameter order Sven Eckelmann
2012-10-04 17:29 ` Luis R. Rodriguez
2012-10-04 17:42 ` Sven Eckelmann
2012-10-04 17:46 ` Luis R. Rodriguez
2012-10-04 17:43 ` [PATCHv2] " Sven Eckelmann
2012-10-04 20:35 ` Luis R. Rodriguez
2012-10-05 16:29 ` Arend van Spriel [this message]
2012-10-05 5:15 ` [PATCH] " Mohammed Shafi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=506F0AD9.70200@broadcom.com \
--to=arend@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mcgrof@qca.qualcomm.com \
--cc=siwu@hrz.tu-chemnitz.de \
--cc=sven@narfation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).