From: "Arend van Spriel" <arend@broadcom.com>
To: "Johannes Berg" <johannes@sipsolutions.net>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: p2p question
Date: Thu, 11 Oct 2012 11:15:22 +0200 [thread overview]
Message-ID: <50768E2A.70400@broadcom.com> (raw)
In-Reply-To: <1349904667.19068.0.camel@jlt4.sipsolutions.net>
On 10/10/2012 11:31 PM, Johannes Berg wrote:
> On Wed, 2012-10-10 at 23:24 +0200, Arend van Spriel wrote:
>> Hi Johannes,
>>
>> Reading the comment on .add_virtual_intf() callback I am a bit confused.
>>
>> =====
>> * @add_virtual_intf: create a new virtual interface with the given name,
>> * must set the struct wireless_dev's iftype. Beware: You must create
>> * the new netdev in the wiphy's network namespace! Returns the struct
>> * wireless_dev, or an ERR_PTR. For P2P device wdevs, the driver must
>> * also set the address member in the wdev.
>> =====
>>
>> The last sentence refers to the "address member in wdev", but at least
>> in my tree struct wireless_dev does not have an address member. Missing
>> something here?
>
> It does in my tree?
>
> struct wireless_dev {
> ...
> u8 address[ETH_ALEN] __aligned(sizeof(u16));
>
> maybe you missed it?
Likely. Still working on 3.6-rc5 so missing "cfg80211: add P2P Device
abstraction". It is probably time to merge, which I was avoiding until
3.7-rc1 was available. Sorry for the noise.
Gr. AvS
prev parent reply other threads:[~2012-10-11 9:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-10 21:24 p2p question Arend van Spriel
2012-10-10 21:31 ` Johannes Berg
2012-10-11 9:15 ` Arend van Spriel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50768E2A.70400@broadcom.com \
--to=arend@broadcom.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).