* p2p question
@ 2012-10-10 21:24 Arend van Spriel
2012-10-10 21:31 ` Johannes Berg
0 siblings, 1 reply; 3+ messages in thread
From: Arend van Spriel @ 2012-10-10 21:24 UTC (permalink / raw)
To: Johannes Berg; +Cc: linux-wireless@vger.kernel.org
Hi Johannes,
Reading the comment on .add_virtual_intf() callback I am a bit confused.
=====
* @add_virtual_intf: create a new virtual interface with the given name,
* must set the struct wireless_dev's iftype. Beware: You must create
* the new netdev in the wiphy's network namespace! Returns the struct
* wireless_dev, or an ERR_PTR. For P2P device wdevs, the driver must
* also set the address member in the wdev.
=====
The last sentence refers to the "address member in wdev", but at least
in my tree struct wireless_dev does not have an address member. Missing
something here?
Gr. AvS
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: p2p question
2012-10-10 21:24 p2p question Arend van Spriel
@ 2012-10-10 21:31 ` Johannes Berg
2012-10-11 9:15 ` Arend van Spriel
0 siblings, 1 reply; 3+ messages in thread
From: Johannes Berg @ 2012-10-10 21:31 UTC (permalink / raw)
To: Arend van Spriel; +Cc: linux-wireless@vger.kernel.org
On Wed, 2012-10-10 at 23:24 +0200, Arend van Spriel wrote:
> Hi Johannes,
>
> Reading the comment on .add_virtual_intf() callback I am a bit confused.
>
> =====
> * @add_virtual_intf: create a new virtual interface with the given name,
> * must set the struct wireless_dev's iftype. Beware: You must create
> * the new netdev in the wiphy's network namespace! Returns the struct
> * wireless_dev, or an ERR_PTR. For P2P device wdevs, the driver must
> * also set the address member in the wdev.
> =====
>
> The last sentence refers to the "address member in wdev", but at least
> in my tree struct wireless_dev does not have an address member. Missing
> something here?
It does in my tree?
struct wireless_dev {
...
u8 address[ETH_ALEN] __aligned(sizeof(u16));
maybe you missed it?
johannes
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: p2p question
2012-10-10 21:31 ` Johannes Berg
@ 2012-10-11 9:15 ` Arend van Spriel
0 siblings, 0 replies; 3+ messages in thread
From: Arend van Spriel @ 2012-10-11 9:15 UTC (permalink / raw)
To: Johannes Berg; +Cc: linux-wireless@vger.kernel.org
On 10/10/2012 11:31 PM, Johannes Berg wrote:
> On Wed, 2012-10-10 at 23:24 +0200, Arend van Spriel wrote:
>> Hi Johannes,
>>
>> Reading the comment on .add_virtual_intf() callback I am a bit confused.
>>
>> =====
>> * @add_virtual_intf: create a new virtual interface with the given name,
>> * must set the struct wireless_dev's iftype. Beware: You must create
>> * the new netdev in the wiphy's network namespace! Returns the struct
>> * wireless_dev, or an ERR_PTR. For P2P device wdevs, the driver must
>> * also set the address member in the wdev.
>> =====
>>
>> The last sentence refers to the "address member in wdev", but at least
>> in my tree struct wireless_dev does not have an address member. Missing
>> something here?
>
> It does in my tree?
>
> struct wireless_dev {
> ...
> u8 address[ETH_ALEN] __aligned(sizeof(u16));
>
> maybe you missed it?
Likely. Still working on 3.6-rc5 so missing "cfg80211: add P2P Device
abstraction". It is probably time to merge, which I was avoiding until
3.7-rc1 was available. Sorry for the noise.
Gr. AvS
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-10-11 9:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-10 21:24 p2p question Arend van Spriel
2012-10-10 21:31 ` Johannes Berg
2012-10-11 9:15 ` Arend van Spriel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).