From: Pontus Fuchs <pontus.fuchs@gmail.com>
To: Kalle Valo <kvalo@adurom.com>
Cc: gregkh@linuxfoundation.org, linux-wireless@vger.kernel.org,
hch@lst.de, s.L-H@gmx.de
Subject: Re: [PATCH 2/4] ar5523: Add driver header file
Date: Sat, 13 Oct 2012 12:14:29 +0200 [thread overview]
Message-ID: <50793F05.7030604@gmail.com> (raw)
In-Reply-To: <87626f0vzw.fsf@purkki.adurom.net>
On 2012-10-13 07:41, Kalle Valo wrote:
> Pontus Fuchs <pontus.fuchs@gmail.com> writes:
>
>> +#define ar5523_err(ar, format, arg...) \
>> +do { \
>> + if (!test_bit(AR5523_USB_DISCONNECTED, &ar->flags)) { \
>> + dev_err(&(ar)->dev->dev, format, ## arg); \
>> + } \
>> +} while (0)
> This looks suspicious and might hide something important. It's better to
> fix the real cause than to workaround it in the error log printer. Do
> you know why this was added?
Yes. The purpose is to hide all the USB errors that happens when you
hot-unplug the dongle. There can be quite a few URBs in flight and
all of them will fail with -ENODEV or -ESHUTDOWN. Instead of checking
for these errors in all the usb submissions and callbacks I added this
flag. Do you still a problem with this approach?
Cheers,
Pontus
next prev parent reply other threads:[~2012-10-13 10:14 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-11 20:01 [PATCH 0/4] Driver for the ar5523 chipset Pontus Fuchs
2012-10-11 20:01 ` [PATCH 1/4] ar5523: Add main driver file Pontus Fuchs
2012-10-15 20:54 ` Luis R. Rodriguez
2012-10-11 20:01 ` [PATCH 2/4] ar5523: Add driver header file Pontus Fuchs
2012-10-13 5:41 ` Kalle Valo
2012-10-13 10:14 ` Pontus Fuchs [this message]
2012-10-13 15:45 ` Christoph Hellwig
2012-10-21 19:58 ` Kalle Valo
2012-10-11 20:01 ` [PATCH 3/4] ar5523: Add Firmware API " Pontus Fuchs
2012-10-11 20:01 ` [PATCH 4/4] ar5523: Add Kconfig and Makefile Pontus Fuchs
2012-10-11 20:31 ` [PATCH 0/4] Driver for the ar5523 chipset Greg KH
2012-10-12 6:52 ` Pontus Fuchs
2012-10-12 7:28 ` Mohammed Shafi
2012-10-12 8:36 ` Pontus Fuchs
2012-10-12 8:23 ` Julian Calaby
2012-10-12 8:33 ` Pontus Fuchs
2012-10-12 11:45 ` Chadd, Adrian
2012-10-30 17:08 ` Adrian Chadd
2012-11-01 17:41 ` Pontus Fuchs
2012-10-12 7:11 ` Kalle Valo
2012-10-12 14:33 ` John W. Linville
2012-10-13 5:38 ` Kalle Valo
2012-10-13 10:25 ` Pontus Fuchs
2012-10-21 16:35 ` Kalle Valo
2012-10-13 15:41 ` Christoph Hellwig
2012-10-13 15:39 ` Christoph Hellwig
2012-10-22 22:43 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50793F05.7030604@gmail.com \
--to=pontus.fuchs@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=kvalo@adurom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=s.L-H@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).