From: Larry Finger <Larry.Finger@lwfinger.net>
To: Christian Lamparter <chunkeey@googlemail.com>
Cc: linux-wireless@vger.kernel.org, Joshua.Roys@gtri.gatech.edu,
linville@tuxdriver.com
Subject: Re: [PATCH] rtlwifi: pass rx setup error code to caller
Date: Sun, 14 Oct 2012 18:14:52 -0500 [thread overview]
Message-ID: <507B476C.7070001@lwfinger.net> (raw)
In-Reply-To: <201210142215.48645.chunkeey@googlemail.com>
On 10/14/2012 03:15 PM, Christian Lamparter wrote:
> If _rtl_usb_receive fails, the device is
> probably not ready. Hence the error code
> should be passed to the caller, so it can
> react accordingly and notify the user.
>
> Signed-off-by: Christian Lamparter <chunkeey@googlemail.com>
> ---
> rtlwifi/usb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
ACKed-by: Larry Finger <Larry.Finger@lwfinger.net>
>
> diff --git a/rtlwifi/usb.c b/rtlwifi/usb.c
> index d7744e1..696d29f 100644
> --- a/rtlwifi/usb.c
> +++ b/rtlwifi/usb.c
> @@ -682,7 +682,7 @@ static int rtl_usb_start(struct ieee80211_hw *hw)
> set_hal_start(rtlhal);
>
> /* Start bulk IN */
> - _rtl_usb_receive(hw);
> + err = _rtl_usb_receive(hw);
> }
>
> return err;
>
prev parent reply other threads:[~2012-10-14 23:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-14 20:15 [PATCH] rtlwifi: pass rx setup error code to caller Christian Lamparter
2012-10-14 23:14 ` Larry Finger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=507B476C.7070001@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=Joshua.Roys@gtri.gatech.edu \
--cc=chunkeey@googlemail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).