* [PATCH] rtlwifi: pass rx setup error code to caller
@ 2012-10-14 20:15 Christian Lamparter
2012-10-14 23:14 ` Larry Finger
0 siblings, 1 reply; 2+ messages in thread
From: Christian Lamparter @ 2012-10-14 20:15 UTC (permalink / raw)
To: Larry.Finger; +Cc: linux-wireless, Joshua.Roys, linville
If _rtl_usb_receive fails, the device is
probably not ready. Hence the error code
should be passed to the caller, so it can
react accordingly and notify the user.
Signed-off-by: Christian Lamparter <chunkeey@googlemail.com>
---
rtlwifi/usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/rtlwifi/usb.c b/rtlwifi/usb.c
index d7744e1..696d29f 100644
--- a/rtlwifi/usb.c
+++ b/rtlwifi/usb.c
@@ -682,7 +682,7 @@ static int rtl_usb_start(struct ieee80211_hw *hw)
set_hal_start(rtlhal);
/* Start bulk IN */
- _rtl_usb_receive(hw);
+ err = _rtl_usb_receive(hw);
}
return err;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rtlwifi: pass rx setup error code to caller
2012-10-14 20:15 [PATCH] rtlwifi: pass rx setup error code to caller Christian Lamparter
@ 2012-10-14 23:14 ` Larry Finger
0 siblings, 0 replies; 2+ messages in thread
From: Larry Finger @ 2012-10-14 23:14 UTC (permalink / raw)
To: Christian Lamparter; +Cc: linux-wireless, Joshua.Roys, linville
On 10/14/2012 03:15 PM, Christian Lamparter wrote:
> If _rtl_usb_receive fails, the device is
> probably not ready. Hence the error code
> should be passed to the caller, so it can
> react accordingly and notify the user.
>
> Signed-off-by: Christian Lamparter <chunkeey@googlemail.com>
> ---
> rtlwifi/usb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
ACKed-by: Larry Finger <Larry.Finger@lwfinger.net>
>
> diff --git a/rtlwifi/usb.c b/rtlwifi/usb.c
> index d7744e1..696d29f 100644
> --- a/rtlwifi/usb.c
> +++ b/rtlwifi/usb.c
> @@ -682,7 +682,7 @@ static int rtl_usb_start(struct ieee80211_hw *hw)
> set_hal_start(rtlhal);
>
> /* Start bulk IN */
> - _rtl_usb_receive(hw);
> + err = _rtl_usb_receive(hw);
> }
>
> return err;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-10-14 23:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-14 20:15 [PATCH] rtlwifi: pass rx setup error code to caller Christian Lamparter
2012-10-14 23:14 ` Larry Finger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).