linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Darren Salt <linux@youmustbejoking.demon.co.uk>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: John Linville <linville@tuxdriver.com>,
	Thiemo Nagel <thiemo.nagel@ph.tum.de>,
	Corentin Chary <corentin.chary@gmail.com>,
	debian-eeepc-devel@lists.alioth.debian.org,
	acpi4asus-user@lists.sourceforge.net,
	linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.31] rfkill: allow toggling soft state in sysfs again
Date: Fri, 10 Jul 2009 22:09:33 +0100	[thread overview]
Message-ID: <507E47A184%linux@youmustbejoking.demon.co.uk> (raw)
In-Reply-To: <1247254899.21972.9.camel@johannes.local>

I demand that Johannes Berg may or may not have written...

> Apparently there actually _are_ tools that try to set this in sysfs even
> though it wasn't supposed to be used this way without claiming first.

Then it should have been documented as such. I don't see anything about this
in Documentation/rfkill.txt (as found in 2.6.30), other than a vague
statement that "Kernel handles events", which isn't exactly helpful :-\

> Guess what: now that I've cleaned it all up it doesn't matter and we can
> simply allow setting the soft-block state in sysfs.

:-)

> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> ---
> *shrug*, I don't like it, but whatever...

I do. It means that we have a nice simple text-based interface for use in
scripts (for now), and a binary interface which is better suited to the likes
of desktop applications.

> Please test & report.

With the patch applied, Bluetooth toggling is working again, so you get to
add this:

Tested-By: Darren Salt <linux@youmustbejoking.demon.co.uk>

[snip]
-- 
| Darren Salt            | linux at youmustbejoking | nr. Ashington, | Doon
| using Debian GNU/Linux | or ds    ,demon,co,uk    | Northumberland | Army
| + Output *more* particulate pollutants.      BUFFER AGAINST GLOBAL WARMING.

For sale: one complete set of hen's teeth.

  reply	other threads:[~2009-07-10 21:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4A5716AA.5000903@ph.tum.de>
     [not found] ` <71cd59b00907100545v6f440a19xfc3668826eb1e509@mail.gmail.com>
     [not found]   ` <4A5743AB.6090303@ph.tum.de>
     [not found]     ` <71cd59b00907100646h5e0283fcyce5874cc4a19106b@mail.gmail.com>
     [not found]       ` <4A575119.9070505@ph.tum.de>
2009-07-10 18:57         ` [2.6.31-rc2] Writing to /sys/class/rfkill/*/state fails Darren Salt
2009-07-10 19:34           ` Corentin Chary
2009-07-10 19:37             ` Marcel Holtmann
2009-07-10 19:41           ` [PATCH 2.6.31] rfkill: allow toggling soft state in sysfs again Johannes Berg
2009-07-10 21:09             ` Darren Salt [this message]
2009-07-10 21:55               ` Johannes Berg
2009-07-10 23:09                 ` Darren Salt
2009-07-25 20:56                 ` [Acpi4asus-user] " Rafael J. Wysocki
2009-07-25 22:35                   ` John W. Linville
2009-07-26 19:32                     ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=507E47A184%linux@youmustbejoking.demon.co.uk \
    --to=linux@youmustbejoking.demon.co.uk \
    --cc=acpi4asus-user@lists.sourceforge.net \
    --cc=corentin.chary@gmail.com \
    --cc=debian-eeepc-devel@lists.alioth.debian.org \
    --cc=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=thiemo.nagel@ph.tum.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).