* [PATCH] brcmfmac: fix potential NULL dereference
@ 2012-10-18 10:10 Yuanhan Liu
2012-10-18 18:32 ` Franky Lin
0 siblings, 1 reply; 2+ messages in thread
From: Yuanhan Liu @ 2012-10-18 10:10 UTC (permalink / raw)
To: linux-wireless, brcm80211-dev-list
Cc: fengguang.wu, Yuanhan Liu, John W. Linville
Fix a samtch warnings catched by Fengguang's 0-DAY system:
+ drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c:3572 brcmf_cfg80211_sched_scan_start() error: we previously assumed 'request' could be null (see line 3571)
Cc: John W. Linville <linville@tuxdriver.com>
Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
---
.../net/wireless/brcm80211/brcmfmac/wl_cfg80211.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c b/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c
index c1abaa6..eaeabee 100644
--- a/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c
+++ b/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c
@@ -3569,7 +3569,7 @@ brcmf_cfg80211_sched_scan_start(struct wiphy *wiphy,
if (!request || !request->n_ssids || !request->n_match_sets) {
WL_ERR("Invalid sched scan req!! n_ssids:%d\n",
- request->n_ssids);
+ request ? request->n_ssids : 0);
return -EINVAL;
}
--
1.7.7.6
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] brcmfmac: fix potential NULL dereference
2012-10-18 10:10 [PATCH] brcmfmac: fix potential NULL dereference Yuanhan Liu
@ 2012-10-18 18:32 ` Franky Lin
0 siblings, 0 replies; 2+ messages in thread
From: Franky Lin @ 2012-10-18 18:32 UTC (permalink / raw)
To: Yuanhan Liu
Cc: linux-wireless, brcm80211-dev-list, fengguang.wu,
John W. Linville
On 10/18/2012 03:10 AM, Yuanhan Liu wrote:
> Fix a samtch warnings catched by Fengguang's 0-DAY system:
> + drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c:3572 brcmf_cfg80211_sched_scan_start() error: we previously assumed 'request' could be null (see line 3571)
>
> Cc: John W. Linville <linville@tuxdriver.com>
> Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
> ---
Thanks
Acked-by: Franky Lin <frankyl@broadcom.com>
Franky
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-10-18 18:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-18 10:10 [PATCH] brcmfmac: fix potential NULL dereference Yuanhan Liu
2012-10-18 18:32 ` Franky Lin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).