From: akolli@codeaurora.org
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: "Toke Høiland-Jørgensen" <toke@toke.dk>,
ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
"Anilkumar Kolli" <akolli@qti.qualcomm.com>,
linux-wireless-owner@vger.kernel.org
Subject: Re: [PATCH 2/2] ath10k: add per peer tx stats support for 10.2.4
Date: Fri, 01 Dec 2017 09:53:30 +0530 [thread overview]
Message-ID: <5080a68538fd2d883e15bacaa969661b@codeaurora.org> (raw)
In-Reply-To: <87bmjjzppd.fsf@kamboji.qca.qualcomm.com>
On 2017-11-30 22:08, Kalle Valo wrote:
> Toke Høiland-Jørgensen <toke@toke.dk> writes:
>
>>>> +struct ath10k_10_2_peer_tx_stats {
>>>> + u8 ratecode[PEER_STATS_FOR_NO_OF_PPDUS];
>>>> + u8 success_pkts[PEER_STATS_FOR_NO_OF_PPDUS];
>>>> + __le16 success_bytes[PEER_STATS_FOR_NO_OF_PPDUS];
>>>> + u8 retry_pkts[PEER_STATS_FOR_NO_OF_PPDUS];
>>>> + __le16 retry_bytes[PEER_STATS_FOR_NO_OF_PPDUS];
>>>> + u8 failed_pkts[PEER_STATS_FOR_NO_OF_PPDUS];
>>>> + __le16 failed_bytes[PEER_STATS_FOR_NO_OF_PPDUS];
>>>> + u8 flags[PEER_STATS_FOR_NO_OF_PPDUS];
>>>> + __le32 tx_duration;
>>>> + u8 tx_ppdu_cnt;
>>>> + u8 peer_id;
>>>> +} __packed;
>>>
>>> Toke, hopefully the tx_duration value here helps with ATF
>>> implementation
>>> using QCA988X.
>>
>> Awesome! What's the semantics of this field? Just total
>> duration spent serving that station in the reporting interval?
>> Does it include retry attempts?
>
> I have no clue :) I just noticed this while I was reviewing the patch
> internally and immediately recalled our discussions at Seoul. I can try
> to find out, but that will take a long time as I have way too much
> stuff
> pending at the moment. Hopefully someone more knowledgeable
> (Anilkumar?)
> can chime in and help.
tx_duration is aggregate time duration of 4 PPDU sent to STA.
FW sends these values for retry packets also.
Thanks,
Anil.
next prev parent reply other threads:[~2017-12-01 4:23 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-30 12:58 [PATCH 0/2] ath10k: tx stats for 10.2.4 akolli
2017-11-30 12:58 ` [PATCH 1/2] ath10k: move pktlog_filter out of ath10k_debug akolli
2017-11-30 12:58 ` [PATCH 2/2] ath10k: add per peer tx stats support for 10.2.4 akolli
2017-11-30 16:14 ` Kalle Valo
2017-11-30 16:28 ` Toke Høiland-Jørgensen
2017-11-30 16:38 ` Kalle Valo
2017-12-01 4:23 ` akolli [this message]
2017-12-01 13:41 ` Toke Høiland-Jørgensen
2017-12-01 14:49 ` Kalle Valo
2017-12-01 15:29 ` Toke Høiland-Jørgensen
2017-12-01 15:45 ` Johannes Berg
2017-12-01 15:54 ` Toke Høiland-Jørgensen
2017-12-01 15:58 ` Johannes Berg
2017-12-02 9:53 ` Toke Høiland-Jørgensen
2017-12-01 10:45 ` Maxime Bizon
2017-12-01 13:48 ` akolli
2017-12-01 15:05 ` Maxime Bizon
2017-12-01 15:53 ` Christian Lamparter
2017-12-01 16:09 ` Maxime Bizon
2017-12-04 13:24 ` akolli
2017-12-04 14:23 ` Maxime Bizon
2017-12-05 5:26 ` akolli
2017-12-01 15:44 ` Kalle Valo
2017-12-04 11:20 ` akolli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5080a68538fd2d883e15bacaa969661b@codeaurora.org \
--to=akolli@codeaurora.org \
--cc=akolli@qti.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless-owner@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).