linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hauke Mehrtens <hauke@hauke-m.de>
To: Zefir Kurtisi <zefir.kurtisi@neratec.com>
Cc: linville@tuxdriver.com, ath9k-devel@lists.ath9k.org,
	linux-wireless@vger.kernel.org, rodrigue@qca.qualcomm.com
Subject: Re: [PATCH] ath9k: [DFS] add pulse width tolerance for ETSI
Date: Wed, 31 Oct 2012 14:32:44 +0100	[thread overview]
Message-ID: <5091287C.9030408@hauke-m.de> (raw)
In-Reply-To: <1351682581-30683-1-git-send-email-zefir.kurtisi@neratec.com>

On 10/31/2012 12:23 PM, Zefir Kurtisi wrote:
> Add 5% width tolerance for radar patterns defined by ETSI.
> 
> Signed-off-by: Zefir Kurtisi <zefir.kurtisi@neratec.com>
> ---
>  .../net/wireless/ath/ath9k/dfs_pattern_detector.c  |    7 ++++++-
>  1 files changed, 6 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/wireless/ath/ath9k/dfs_pattern_detector.c b/drivers/net/wireless/ath/ath9k/dfs_pattern_detector.c
> index 3b12914..24877b0 100644
> --- a/drivers/net/wireless/ath/ath9k/dfs_pattern_detector.c
> +++ b/drivers/net/wireless/ath/ath9k/dfs_pattern_detector.c
> @@ -42,10 +42,15 @@ struct radar_types {
>  #define MIN_PPB_THRESH	50
>  #define PPB_THRESH(PPB) ((PPB * MIN_PPB_THRESH + 50) / 100)
>  #define PRF2PRI(PRF) ((1000000 + PRF / 2) / PRF)
> +/* percentage of pulse width tolerance */
> +#define WIDTH_TOLERANCE 5
> +#define WIDTH_LOWER(X) ((X*(100-WIDTH_TOLERANCE)+50)/100)
> +#define WIDTH_UPPER(X) ((X*(100+WIDTH_TOLERANCE)+50)/100)
                                                   ^^^
Why are you adding 50 there? If you want to just add 5% tolerance, then
the +50 is wrong there, but I do not know anything about radar patterns
defined by ETSI.

Hauke

  reply	other threads:[~2012-10-31 13:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-31 11:23 [PATCH] ath9k: [DFS] add pulse width tolerance for ETSI Zefir Kurtisi
2012-10-31 13:32 ` Hauke Mehrtens [this message]
2012-10-31 13:57   ` Felix Fietkau
2012-10-31 14:38     ` Zefir Kurtisi
2012-10-31 13:59   ` Zefir Kurtisi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5091287C.9030408@hauke-m.de \
    --to=hauke@hauke-m.de \
    --cc=ath9k-devel@lists.ath9k.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=rodrigue@qca.qualcomm.com \
    --cc=zefir.kurtisi@neratec.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).