From: Ben Greear <greearb@candelatech.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: WARNING in agg-tx.c (3.5.7+, not tainted)
Date: Wed, 31 Oct 2012 12:18:34 -0700 [thread overview]
Message-ID: <5091798A.7010104@candelatech.com> (raw)
In-Reply-To: <1351710647.6281.10.camel@jlt4.sipsolutions.net>
On 10/31/2012 12:10 PM, Johannes Berg wrote:
> On Wed, 2012-10-31 at 11:54 -0700, Ben Greear wrote:
>> While trying to debug another kernel splat, I saw this one. System was
>> in process of creating and getting DHCP for 400 virtual stations.
>>
>> Code in question:
>>
>>
>>
>> mutex_lock(&sta->ampdu_mlme.mtx);
>> tid_tx = rcu_dereference_protected_tid_tx(sta, tid);
>>
>> if (WARN_ON(!tid_tx)) {
>> #ifdef CONFIG_MAC80211_HT_DEBUG
>> printk(KERN_DEBUG "addBA was not requested!\n");
>> #endif
>
> Hm should probably be a WARN(), but ...
>
>>From the backtrace it looks like maybe you were tearing down the
> interface? So maybe it's possible that you were remove it or something,
> and the driver had just accepted the session? Hmm.
I've got 400 interfaces churning, some being reset due to lack of
fast enough DHCP response, etc. Could easily be related to that
drv-remove-interface bug as well..it is much more easily reproduced
in this scenario. Will re-run some tests with your suggested patch
applied...
Thanks,
Ben
>
> johannes
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2012-10-31 19:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-31 18:54 WARNING in agg-tx.c (3.5.7+, not tainted) Ben Greear
2012-10-31 19:10 ` Johannes Berg
2012-10-31 19:18 ` Ben Greear [this message]
2012-10-31 19:20 ` Johannes Berg
2012-10-31 23:44 ` Ben Greear
2012-11-14 9:37 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5091798A.7010104@candelatech.com \
--to=greearb@candelatech.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).