From: Larry Finger <Larry.Finger@lwfinger.net>
To: Maxim Mikityanskiy <maxtram95@gmail.com>
Cc: greg@kroah.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 00/17] RTL8187SE driver cleanups
Date: Mon, 12 Nov 2012 16:37:31 -0600 [thread overview]
Message-ID: <50A17A2B.6060301@lwfinger.net> (raw)
In-Reply-To: <1352757511-26957-1-git-send-email-maxtram95@gmail.com>
On 11/12/2012 03:58 PM, Maxim Mikityanskiy wrote:
> There are some bug fixes, cleanups and dead code removal for
> drivers/staging/rtl8187se
There is a serious problems with your patches. The text in
Documentation/SubmittingPatches says:
"All changes to the Linux kernel occur in the form of patches, as
generated by diff(1). When creating your patch, make sure to create it
in "unified diff" format, as supplied by the '-u' argument to diff(1).
Also, please use the '-p' argument which shows which C function each
change is in - that makes the resultant diff a lot easier to read.
Patches should be based in the root kernel source directory,
not in any lower subdirectory."
You satisfied the requirements for -u and -p, but you based then on the wrong
directory. I can use sed to rewrite this version for testing, but please use the
correct base in future versions.
Larry
next prev parent reply other threads:[~2012-11-12 22:37 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-12 21:58 [PATCH 00/17] RTL8187SE driver cleanups Maxim Mikityanskiy
2012-11-12 21:58 ` [PATCH 01/17] Removed dead functions Maxim Mikityanskiy
2012-11-12 21:58 ` [PATCH 02/17] Removed legacy rtl8225_rf_set_chan() Maxim Mikityanskiy
2012-11-12 21:58 ` [PATCH 03/17] Removed empty functions and one-iteration loop Maxim Mikityanskiy
2012-11-12 21:58 ` [PATCH 04/17] Fixed bugs in interrupt handler Maxim Mikityanskiy
2012-11-12 21:58 ` [PATCH 05/17] Simplified function GetSupportedWirelessMode8185() Maxim Mikityanskiy
2012-11-12 21:58 ` [PATCH 06/17] Fix oops when rmmoding Maxim Mikityanskiy
2012-11-12 21:58 ` [PATCH 07/17] Removed unused module parameters and fixed module description Maxim Mikityanskiy
2012-11-12 21:58 ` [PATCH 08/17] Removed dead code Maxim Mikityanskiy
2012-11-12 21:58 ` [PATCH 09/17] Removed unused parameters of HwHSSIThreeWire() Maxim Mikityanskiy
2012-11-12 21:58 ` [PATCH 10/17] Fixed typo in TransmitConfig Maxim Mikityanskiy
2012-11-12 21:58 ` [PATCH 11/17] Removed non-existent function headers from r8180.h Maxim Mikityanskiy
2012-11-12 21:58 ` [PATCH 12/17] Removed unused arrays in r8180_rtl8225z2.c Maxim Mikityanskiy
2012-11-12 21:58 ` [PATCH 13/17] Use ARRAY_SIZE instead of in-code constants Maxim Mikityanskiy
2012-11-12 21:58 ` [PATCH 14/17] Removed unneeded reads from EEPROM Maxim Mikityanskiy
2012-11-12 21:58 ` [PATCH 15/17] Removed unused fields in r8180_priv Maxim Mikityanskiy
2012-11-12 23:31 ` Larry Finger
2012-11-13 17:25 ` Maxim Mikityanskiy
2012-11-12 21:58 ` [PATCH 16/17] Fixed size of BEACON_INTERVAL register Maxim Mikityanskiy
2012-11-12 21:58 ` [PATCH 17/17] Removed empty stub read_acadapter_file() Maxim Mikityanskiy
2012-11-12 22:19 ` [PATCH 00/17] RTL8187SE driver cleanups Larry Finger
2012-11-13 17:15 ` Maxim Mikityanskiy
2012-11-12 22:37 ` Larry Finger [this message]
2012-11-12 23:07 ` Greg KH
2012-11-13 17:18 ` Maxim Mikityanskiy
2012-11-13 17:51 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50A17A2B.6060301@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=greg@kroah.com \
--cc=linux-wireless@vger.kernel.org \
--cc=maxtram95@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).