* [PATCH -next] wireless: brcmfmac: fix printk format warning [not found] <20121101163622.129b59967d2ee76e6946874a@canb.auug.org.au> @ 2012-11-01 17:43 ` Randy Dunlap 2012-11-01 18:01 ` Arend van Spriel 0 siblings, 1 reply; 7+ messages in thread From: Randy Dunlap @ 2012-11-01 17:43 UTC (permalink / raw) To: Stephen Rothwell Cc: linux-next, linux-kernel, brcm80211-dev-list, linux-wireless From: Randy Dunlap <rdunlap@infradead.org> Fix printk format warning for ssid_len, which is a size_t: drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c:3941:2: warning: format '%d' expects type 'int', but argument 4 has type 'size_t' Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: brcm80211-dev-list@broadcom.com --- drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20121101.orig/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c +++ linux-next-20121101/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c @@ -3938,7 +3938,7 @@ brcmf_cfg80211_start_ap(struct wiphy *wi WL_TRACE("channel_type=%d, beacon_interval=%d, dtim_period=%d,\n", settings->channel_type, settings->beacon_interval, settings->dtim_period); - WL_TRACE("ssid=%s(%d), auth_type=%d, inactivity_timeout=%d\n", + WL_TRACE("ssid=%s(%zu), auth_type=%d, inactivity_timeout=%d\n", settings->ssid, settings->ssid_len, settings->auth_type, settings->inactivity_timeout); ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH -next] wireless: brcmfmac: fix printk format warning 2012-11-01 17:43 ` [PATCH -next] wireless: brcmfmac: fix printk format warning Randy Dunlap @ 2012-11-01 18:01 ` Arend van Spriel 2012-11-01 19:31 ` Johannes Berg 0 siblings, 1 reply; 7+ messages in thread From: Arend van Spriel @ 2012-11-01 18:01 UTC (permalink / raw) To: Randy Dunlap Cc: Stephen Rothwell, linux-next, linux-kernel, brcm80211-dev-list, linux-wireless On 11/01/2012 06:43 PM, Randy Dunlap wrote: > From: Randy Dunlap <rdunlap@infradead.org> > > Fix printk format warning for ssid_len, which is a size_t: > > drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c:3941:2: warning: format '%d' expects type 'int', but argument 4 has type 'size_t' > > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: brcm80211-dev-list@broadcom.com We actually have a patch ready for that with credit to people who reported it. We can add you to that list ;-) Gr. AvS ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH -next] wireless: brcmfmac: fix printk format warning 2012-11-01 18:01 ` Arend van Spriel @ 2012-11-01 19:31 ` Johannes Berg 2012-11-01 20:51 ` Arend van Spriel 2012-11-13 15:55 ` Randy Dunlap 0 siblings, 2 replies; 7+ messages in thread From: Johannes Berg @ 2012-11-01 19:31 UTC (permalink / raw) To: Arend van Spriel Cc: Randy Dunlap, Stephen Rothwell, linux-next, linux-kernel, brcm80211-dev-list, linux-wireless On Thu, 2012-11-01 at 19:01 +0100, Arend van Spriel wrote: > On 11/01/2012 06:43 PM, Randy Dunlap wrote: > > From: Randy Dunlap <rdunlap@infradead.org> > > > > Fix printk format warning for ssid_len, which is a size_t: > > > > drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c:3941:2: warning: format '%d' expects type 'int', but argument 4 has type 'size_t' > > > > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > > Cc: brcm80211-dev-list@broadcom.com > > > We actually have a patch ready for that with credit to people who > reported it. We can add you to that list ;-) Which you've been sitting on for WAY too long already :) johannes ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH -next] wireless: brcmfmac: fix printk format warning 2012-11-01 19:31 ` Johannes Berg @ 2012-11-01 20:51 ` Arend van Spriel 2012-11-01 21:14 ` Randy Dunlap 2012-11-13 15:55 ` Randy Dunlap 1 sibling, 1 reply; 7+ messages in thread From: Arend van Spriel @ 2012-11-01 20:51 UTC (permalink / raw) To: Johannes Berg Cc: Randy Dunlap, Stephen Rothwell, linux-next, linux-kernel, brcm80211-dev-list, linux-wireless On 11/01/2012 08:31 PM, Johannes Berg wrote: > On Thu, 2012-11-01 at 19:01 +0100, Arend van Spriel wrote: >> On 11/01/2012 06:43 PM, Randy Dunlap wrote: >>> From: Randy Dunlap <rdunlap@infradead.org> >>> >>> Fix printk format warning for ssid_len, which is a size_t: >>> >>> drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c:3941:2: warning: format '%d' expects type 'int', but argument 4 has type 'size_t' >>> >>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org> >>> Cc: brcm80211-dev-list@broadcom.com >> >> >> We actually have a patch ready for that with credit to people who >> reported it. We can add you to that list ;-) > > Which you've been sitting on for WAY too long already :) > > johannes > > True. I was actually going to make Hante fix it, but failed my management skills miserably. Fixed it myself in the end. There are quite a number of patches queued up. Another flush() not working :-) Gr. AvS ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH -next] wireless: brcmfmac: fix printk format warning 2012-11-01 20:51 ` Arend van Spriel @ 2012-11-01 21:14 ` Randy Dunlap 0 siblings, 0 replies; 7+ messages in thread From: Randy Dunlap @ 2012-11-01 21:14 UTC (permalink / raw) To: Arend van Spriel Cc: Johannes Berg, Stephen Rothwell, linux-next, linux-kernel, brcm80211-dev-list, linux-wireless On 11/01/2012 01:51 PM, Arend van Spriel wrote: > On 11/01/2012 08:31 PM, Johannes Berg wrote: >> On Thu, 2012-11-01 at 19:01 +0100, Arend van Spriel wrote: >>> On 11/01/2012 06:43 PM, Randy Dunlap wrote: >>>> From: Randy Dunlap <rdunlap@infradead.org> >>>> >>>> Fix printk format warning for ssid_len, which is a size_t: >>>> >>>> drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c:3941:2: warning: format '%d' expects type 'int', but argument 4 has type 'size_t' >>>> >>>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org> >>>> Cc: brcm80211-dev-list@broadcom.com >>> >>> >>> We actually have a patch ready for that with credit to people who >>> reported it. We can add you to that list ;-) >> >> Which you've been sitting on for WAY too long already :) >> >> johannes >> >> > > True. I was actually going to make Hante fix it, but failed my > management skills miserably. Fixed it myself in the end. There are quite > a number of patches queued up. Another flush() not working :-) Please get them into your linux-next tree so that we don't waste time fixing things that are already fixed. thanks, -- ~Randy ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH -next] wireless: brcmfmac: fix printk format warning 2012-11-01 19:31 ` Johannes Berg 2012-11-01 20:51 ` Arend van Spriel @ 2012-11-13 15:55 ` Randy Dunlap 2012-11-13 21:52 ` Arend van Spriel 1 sibling, 1 reply; 7+ messages in thread From: Randy Dunlap @ 2012-11-13 15:55 UTC (permalink / raw) To: Johannes Berg Cc: Arend van Spriel, Stephen Rothwell, linux-next, linux-kernel, brcm80211-dev-list, linux-wireless On 11/01/2012 12:31 PM, Johannes Berg wrote: > On Thu, 2012-11-01 at 19:01 +0100, Arend van Spriel wrote: >> On 11/01/2012 06:43 PM, Randy Dunlap wrote: >>> From: Randy Dunlap <rdunlap@infradead.org> >>> >>> Fix printk format warning for ssid_len, which is a size_t: >>> >>> drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c:3941:2: warning: format '%d' expects type 'int', but argument 4 has type 'size_t' >>> >>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org> >>> Cc: brcm80211-dev-list@broadcom.com >> >> >> We actually have a patch ready for that with credit to people who >> reported it. We can add you to that list ;-) > > Which you've been sitting on for WAY too long already :) ping Arend. Please have your patch included in linux-next builds. thanks. -- ~Randy ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH -next] wireless: brcmfmac: fix printk format warning 2012-11-13 15:55 ` Randy Dunlap @ 2012-11-13 21:52 ` Arend van Spriel 0 siblings, 0 replies; 7+ messages in thread From: Arend van Spriel @ 2012-11-13 21:52 UTC (permalink / raw) To: Randy Dunlap Cc: Johannes Berg, Stephen Rothwell, linux-next, linux-kernel, brcm80211-dev-list, linux-wireless, John W. Linville On 11/13/2012 04:55 PM, Randy Dunlap wrote: > On 11/01/2012 12:31 PM, Johannes Berg wrote: > >> On Thu, 2012-11-01 at 19:01 +0100, Arend van Spriel wrote: >>> On 11/01/2012 06:43 PM, Randy Dunlap wrote: >>>> From: Randy Dunlap <rdunlap@infradead.org> >>>> >>>> Fix printk format warning for ssid_len, which is a size_t: >>>> >>>> drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c:3941:2: warning: format '%d' expects type 'int', but argument 4 has type 'size_t' >>>> >>>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org> >>>> Cc: brcm80211-dev-list@broadcom.com >>> >>> >>> We actually have a patch ready for that with credit to people who >>> reported it. We can add you to that list ;-) >> >> Which you've been sitting on for WAY too long already :) > > ping Arend. > Please have your patch included in linux-next builds. thanks. > It has been posted to John on November 6th. The wireless summit in Barcelona probably gave some delay. It is on the wireless list named "[PATCH 19/24] brcmfmac: fix build regression". Gr. AvS ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2012-11-13 21:52 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20121101163622.129b59967d2ee76e6946874a@canb.auug.org.au>
2012-11-01 17:43 ` [PATCH -next] wireless: brcmfmac: fix printk format warning Randy Dunlap
2012-11-01 18:01 ` Arend van Spriel
2012-11-01 19:31 ` Johannes Berg
2012-11-01 20:51 ` Arend van Spriel
2012-11-01 21:14 ` Randy Dunlap
2012-11-13 15:55 ` Randy Dunlap
2012-11-13 21:52 ` Arend van Spriel
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).