linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Arend van Spriel" <arend@broadcom.com>
To: "Johannes Berg" <johannes@sipsolutions.net>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"John W. Linville" <linville@tuxdriver.com>
Subject: rework on .flush() callback
Date: Thu, 15 Nov 2012 13:47:20 +0100	[thread overview]
Message-ID: <50A4E458.4090508@broadcom.com> (raw)

Hi Johannes,

The brcmsmac driver still faces a lot of bug reports related to the 
.flush() callback (see [1] from Dave Jones).

Previously I had looked into this and found that during the flush the 
.tx callback still gets new frames. So I put ieee80211_stop_queues() in 
the flush and upon exit call ieee80211_wake_queues(). Due to issues 
still persisting we went a bit deeper in mac80211.

It turns out that mac80211 stops the netif queues for each interface 
(except monitor iftype) and not the internal queues during a scan. So it 
stops the netif queues, calls the flush(), and upon returning to the 
associated channel it wakes up the netif queues.

The problem here is that in brcmsmac the flush does the 
ieee80211_wake_queues() call, because that could also wakeup the netif 
queues. So doing it in the driver seems a bad idea. Any suggestion on 
how to solve this?

off topic question: boy or girl?

Gr. AvS

[1] http://codemonkey.org.uk/2012/11/09/brcmsmac-bugs/


             reply	other threads:[~2012-11-15 12:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-15 12:47 Arend van Spriel [this message]
2012-11-16 13:34 ` rework on .flush() callback Johannes Berg
2012-11-16 17:08   ` Arend van Spriel
2012-11-19 14:52     ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50A4E458.4090508@broadcom.com \
    --to=arend@broadcom.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).