From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mms3.broadcom.com ([216.31.210.19]:4868 "EHLO mms3.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750816Ab2KPIh2 (ORCPT ); Fri, 16 Nov 2012 03:37:28 -0500 Message-ID: <50A5FB05.4040500@broadcom.com> (sfid-20121116_093731_533991_F071A28D) Date: Fri, 16 Nov 2012 09:36:21 +0100 From: "Arend van Spriel" MIME-Version: 1.0 To: "Seth Forshee" cc: linux-wireless@vger.kernel.org, "John W. Linville" , "Franky (Zhenhui) Lin" , "Brett Rudley" , "Roland Vossen" , brcm80211-dev-list@broadcom.com, "Daniel Wagner" Subject: Re: [PATCH v2 01/22] brcmsmac: Introduce AMPDU sessions for assembling AMPDUs References: <1352988492-21340-1-git-send-email-seth.forshee@canonical.com> <1352988492-21340-2-git-send-email-seth.forshee@canonical.com> In-Reply-To: <1352988492-21340-2-git-send-email-seth.forshee@canonical.com> Content-Type: text/plain; charset=iso-8859-1; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 11/15/2012 03:07 PM, Seth Forshee wrote: > AMPDU session allows MPDUs to be temporarily queued until either a full > AMPDU has been collected or circumstances dictate that transmission > should start with a partial AMPDU. Packets are added to the session by I started reviewing this and reading this commit message got me wondering about the .flush() problems. I realized the flush would be a "circumstance" to start transmission of a partial AMPDU, but I am pretty sure it currently is not treated as such. Regards, Arend > calling brcms_c_ampdu_add_frame(). brcms_c_ampdu_finalize() should be > called to fix up the tx headers in the first and last packet before > adding the packets to the DMA ring. brmcs_c_sendampdu() is converted to > using AMPDU sessions. > > This patch has no real value on it's own, but is needed in preparation > for elimination of the tx packet queue from brcmsmac. > > Signed-off-by: Seth Forshee > --- > drivers/net/wireless/brcm80211/brcmsmac/ampdu.c | 625 +++++++++++++---------- > drivers/net/wireless/brcm80211/brcmsmac/ampdu.h | 26 + > 2 files changed, 377 insertions(+), 274 deletions(-)