From: "Arend van Spriel" <arend@broadcom.com>
To: "Seth Forshee" <seth.forshee@canonical.com>
Cc: linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
"Franky (Zhenhui) Lin" <frankyl@broadcom.com>,
"Brett Rudley" <brudley@broadcom.com>,
"Roland Vossen" <rvossen@broadcom.com>,
brcm80211-dev-list@broadcom.com, "Daniel Wagner" <wagi@monom.org>
Subject: Re: [PATCH v2 01/22] brcmsmac: Introduce AMPDU sessions for assembling AMPDUs
Date: Fri, 16 Nov 2012 16:02:30 +0100 [thread overview]
Message-ID: <50A65586.9080102@broadcom.com> (raw)
In-Reply-To: <20121116141255.GA19078@thinkpad-t410>
On 11/16/2012 03:12 PM, Seth Forshee wrote:
> What does strike me as problematic is the locking in brcms_ops_flush().
> It holds wl->lock, and the interrupt handling tries to acquire the same
> lock. Doesn't this prevent both the txpktpend counts from getting
> updated and any more packets being transmitted from the packet queue?
>
> Seth
>
Actually, in the brcms_c_wait_for_tx_completion() the while loop does a
brcms_msleep() which releases the wl->lock, does an msleep() and
acquires the lock. At least that is what is currently in
wireless-testing. I changed it internally to wait_for_event() mechanism,
but it was not accepted as people still were seeing issues.
Gr. AvS
next prev parent reply other threads:[~2012-11-16 15:02 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-15 14:07 [PATCH v2 00/22] brcmsmac: Tx rework and expanded debug/trace support Seth Forshee
2012-11-15 14:07 ` [PATCH v2 01/22] brcmsmac: Introduce AMPDU sessions for assembling AMPDUs Seth Forshee
2012-11-16 8:36 ` Arend van Spriel
2012-11-16 14:12 ` Seth Forshee
2012-11-16 15:02 ` Arend van Spriel [this message]
2012-11-16 15:18 ` Seth Forshee
2012-11-19 18:33 ` Arend van Spriel
2012-11-15 14:07 ` [PATCH v2 02/22] brcmsmac: Don't weight AMPDU packets in txfifo Seth Forshee
2012-11-19 18:34 ` Arend van Spriel
2012-11-15 14:07 ` [PATCH v2 03/22] brcmsmac: Add helper function for updating txavail count Seth Forshee
2012-11-19 18:35 ` Arend van Spriel
2012-11-15 14:07 ` [PATCH v2 04/22] brcmsmac: Remove unimplemented flow control functions Seth Forshee
2012-11-19 18:35 ` Arend van Spriel
2012-11-15 14:07 ` [PATCH v2 05/22] brcmsmac: Use IEEE 802.11 AC levels for pktq precedence levels Seth Forshee
2012-11-19 18:42 ` Arend van Spriel
2012-11-19 19:16 ` Seth Forshee
2012-11-19 20:50 ` Arend van Spriel
2012-11-15 14:07 ` [PATCH v2 06/22] brcmsmac: Remove internal tx queue Seth Forshee
2012-11-19 18:47 ` Arend van Spriel
2012-11-15 14:07 ` [PATCH v2 07/22] brcmsmac: Use correct descriptor count when calculating next rx descriptor Seth Forshee
2012-11-15 14:07 ` [PATCH v2 08/22] brcmsmac: Reduce number of entries in tx DMA rings Seth Forshee
2012-11-19 18:47 ` Arend van Spriel
2012-11-15 14:07 ` [PATCH v2 09/22] brcm80211: Allow trace support to be enabled separately from debug Seth Forshee
2012-11-19 20:33 ` Arend van Spriel
2012-11-19 21:15 ` Seth Forshee
2012-11-19 21:19 ` Arend van Spriel
2012-11-19 21:33 ` Seth Forshee
2012-11-27 16:22 ` Seth Forshee
2012-11-15 14:08 ` [PATCH v2 10/22] brcm80211: Convert log message levels to debug levels Seth Forshee
2012-11-15 14:08 ` [PATCH v2 11/22] brcmsmac: Add module parameter for setting the debug level Seth Forshee
2012-11-19 20:35 ` Arend van Spriel
2012-11-15 14:08 ` [PATCH v2 12/22] brcmsmac: Add support for writing debug messages to the trace buffer Seth Forshee
2012-11-19 20:35 ` Arend van Spriel
2012-11-22 13:42 ` Arend van Spriel
2012-11-15 14:08 ` [PATCH v2 13/22] brcmsmac: Use debug macros for general error and debug statements Seth Forshee
2012-11-15 14:08 ` [PATCH v2 14/22] brcmsmac: Add brcms_dbg_mac80211() debug macro Seth Forshee
2012-11-19 20:36 ` Arend van Spriel
2012-11-15 14:08 ` [PATCH v2 15/22] brcmsmac: Add rx and tx debug macros Seth Forshee
2012-11-19 20:37 ` Arend van Spriel
2012-11-15 14:08 ` [PATCH v2 16/22] brcmsmac: Add brcms_dbg_int() debug macro Seth Forshee
2012-11-19 20:37 ` Arend van Spriel
2012-11-15 14:08 ` [PATCH v2 17/22] brcmsmac: Add brcms_dbg_dma() " Seth Forshee
2012-11-19 20:38 ` Arend van Spriel
2012-11-15 14:08 ` [PATCH v2 18/22] brcmsmac: Add brcms_dbg_ht() " Seth Forshee
2012-11-19 20:39 ` Arend van Spriel
2012-11-15 14:08 ` [PATCH v2 19/22] brcmsmac: Improve tx trace and debug support Seth Forshee
2012-11-15 14:08 ` [PATCH v2 20/22] brcmsmac: Add tracepoint for macintstatus Seth Forshee
2012-11-15 14:08 ` [PATCH v2 21/22] brcmsmac: Add tracepoint for AMPDU session information Seth Forshee
2012-11-15 14:08 ` [PATCH v2 22/22] brcmsmac: Remove some noisy and uninformative debug messages Seth Forshee
2012-11-15 19:47 ` [PATCH v2 00/22] brcmsmac: Tx rework and expanded debug/trace support Arend van Spriel
2012-11-19 19:11 ` Daniel Wagner
2012-11-20 7:30 ` Daniel Wagner
2012-11-20 14:28 ` Seth Forshee
2012-11-20 17:44 ` Daniel Wagner
2012-11-20 20:54 ` Seth Forshee
2012-11-20 22:35 ` Daniel Wagner
2012-11-20 22:45 ` Daniel Wagner
2012-11-21 9:44 ` Arend van Spriel
2012-11-21 9:56 ` Daniel Wagner
2012-11-21 14:35 ` Seth Forshee
2012-11-21 17:56 ` Arend van Spriel
2012-11-23 7:32 ` Daniel Wagner
2012-11-26 19:36 ` Seth Forshee
2012-11-26 21:20 ` Daniel Wagner
2012-12-03 8:23 ` Daniel Wagner
2012-12-03 8:37 ` Arend van Spriel
2012-12-03 10:15 ` Daniel Wagner
2012-12-03 17:40 ` Arend van Spriel
2012-12-04 7:25 ` Daniel Wagner
2012-12-05 8:16 ` Daniel Wagner
2012-11-20 21:09 ` Arend van Spriel
2012-11-20 21:16 ` Seth Forshee
2012-11-20 21:51 ` Arend van Spriel
2012-11-20 22:36 ` Seth Forshee
2012-11-20 22:35 ` Daniel Wagner
2012-11-19 20:45 ` Arend van Spriel
2012-11-19 21:33 ` Seth Forshee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50A65586.9080102@broadcom.com \
--to=arend@broadcom.com \
--cc=brcm80211-dev-list@broadcom.com \
--cc=brudley@broadcom.com \
--cc=frankyl@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=rvossen@broadcom.com \
--cc=seth.forshee@canonical.com \
--cc=wagi@monom.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).