From: Mark Ellis <m@rkellis.com>
To: Arend van Spriel <arend@broadcom.com>
Cc: linux-kernel@vger.kernel.org,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Piotr Haber <phaber@broadcom.com>
Subject: Re: PROBLEM: REGRESSION in drivers/platform/x86/dell-laptop.c
Date: Mon, 19 Nov 2012 18:11:15 +0800 [thread overview]
Message-ID: <50AA05C3.8030005@rkellis.com> (raw)
In-Reply-To: <50A92935.5070802@broadcom.com>
On 19/11/12 02:30, Arend van Spriel wrote:
> On 11/18/2012 11:47 AM, Mark Ellis wrote:
>> 1. rfkill code removal causes hang
>>
>> 2. the rfkill code was removed from this driver in commit
>> 53039f222c548bfc119eea6df4dca2b57550e271 this results in my computer
>> hanging (dell n5050) if booting with the wireless (hardware) disabled.
>> downgrading this module to the version prior to this commit fixes the
>> issue.
>
> The commit you mention does not touch dell-laptop.c. The commit before
> that one doe, but it is only adding code. Digging the tree I found this
> one between kernel v3.4 and v3.5-rc1:
>
> commit a6c2390cd6d2083d27a2359658e08f2d3df375ac
> Author: Matthew Garrett <mjg@redhat.com>
> Date: Fri Jun 1 12:46:56 2012 -0400
>
> dell-laptop: Remove rfkill code
>
> The interface just doesn't work on some machines, and Dell haven't been
> able to tell us either which machines those are or what we should be
> doing instead. This would be fine, except it results in userspace ending
> up confused and general sadness. So let's just rip it out for now.
>
> Signed-off-by: Matthew Garrett <mjg@redhat.com>
You're right, I have no idea where I got that commit number from! Sorry
about that.
> Actually, the behavior you describe and given you have a BCM4313 running
> with brcmsmac I may point out that this driver has an issue coming up
> with wireless disabled. This has been fixed in 3.7 kernel so you may
> want to try:
>
> commit 82d8eba358badb466a4e988ecabf0668a8d92e9c
> Author: Piotr Haber <phaber@broadcom.com>
> Date: Wed Sep 19 22:21:15 2012 +0200
>
> brcmsmac: don't start device when RfKill is engaged
>
> This patch fixes a bug when device is being started
> while RfKill switch is engaged, leading to hang
> due to partial initialization of hardware.
>
> Tested-by: <dragonn@op.pl>
> Reviewed-by: Arend van Spriel <arend@broadcom.com>
> Reviewed-by: Hante Meuleman <meuleman@broadcom.com>
> Signed-off-by: Piotr Haber <phaber@broadcom.com>
> Signed-off-by: Arend van Spriel <arend@broadcom.com>
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
>
> Maybe I should resubmit it to stable. Now there is an idea.
Yep that fixed it, thanks very much!
Mark
prev parent reply other threads:[~2012-11-19 10:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <50A8BCA6.7080102@rkellis.com>
2012-11-18 18:30 ` PROBLEM: REGRESSION in drivers/platform/x86/dell-laptop.c Arend van Spriel
2012-11-19 10:11 ` Mark Ellis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50AA05C3.8030005@rkellis.com \
--to=m@rkellis.com \
--cc=arend@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=phaber@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).