linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Arend van Spriel" <arend@broadcom.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org,
	"Fengguang Wu" <fengguang.wu@intel.com>,
	"Franky Lin" <frankyl@broadcom.com>
Subject: Re: [PATCH] brcmfmac: check return from kzalloc in brcmf_fweh_process_event
Date: Mon, 19 Nov 2012 18:39:11 +0100	[thread overview]
Message-ID: <50AA6EBF.9050001@broadcom.com> (raw)
In-Reply-To: <1353340412-22757-1-git-send-email-linville@tuxdriver.com>

On 11/19/2012 04:53 PM, John W. Linville wrote:
> From: "John W. Linville" <linville@tuxdriver.com>
>
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
>   drivers/net/wireless/brcm80211/brcmfmac/fweh.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/wireless/brcm80211/brcmfmac/fweh.c b/drivers/net/wireless/brcm80211/brcmfmac/fweh.c
> index 1e4188c..fa8fc44 100644
> --- a/drivers/net/wireless/brcm80211/brcmfmac/fweh.c
> +++ b/drivers/net/wireless/brcm80211/brcmfmac/fweh.c
> @@ -494,6 +494,9 @@ void brcmf_fweh_process_event(struct brcmf_pub *drvr,
>   		alloc_flag = GFP_ATOMIC;
>
>   	event = kzalloc(sizeof(*event) + datalen, alloc_flag);
> +	if (!event)

My fix included a debug statement about the discarded event from firmware.

> +		return;
> +
>   	event->code = code;
>   	event->ifidx = *ifidx;
>
>

I will deal with the merge so:

Acked-by: Arend van Spriel <arend@broadcom.com>

Gr. AvS


  reply	other threads:[~2012-11-19 17:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-19 15:53 [PATCH] brcmfmac: check return from kzalloc in brcmf_fweh_process_event John W. Linville
2012-11-19 17:39 ` Arend van Spriel [this message]
2012-11-20  7:57   ` Kalle Valo
2012-11-20 19:51     ` Arend van Spriel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50AA6EBF.9050001@broadcom.com \
    --to=arend@broadcom.com \
    --cc=fengguang.wu@intel.com \
    --cc=frankyl@broadcom.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).