[RFC] mac80211: add debugfs file for current tx rate

[RFC] mac80211: add debugfs file for current tx rate

[saravanad]

Add a debugfs file showing the current tx rate.
The information available in the rc_stats file
doesn't evidently provides us the current tx rate.
This patch adds the support for the same.

Signed-off-by: Saravana <saravanad@posedge.com>
---
The diff file is generated from wireless-testing git tree.
  net/mac80211/debugfs_sta.c |   16 ++++++++++++++++
  1 files changed, 16 insertions(+), 0 deletions(-)

diff --git a/net/mac80211/debugfs_sta.c b/net/mac80211/debugfs_sta.c
index 89281d2..85d2279 100644
--- a/net/mac80211/debugfs_sta.c
+++ b/net/mac80211/debugfs_sta.c
@@ -321,6 +321,21 @@ static ssize_t sta_ht_capa_read(struct file *file, 
char __user *userbuf,
  }
  STA_OPS(ht_capa);

+static ssize_t sta_current_tx_rate_read(struct file *file, char __user 
*userbuf,
+				      size_t count, loff_t *ppos)
+{
+	struct sta_info *sta = file->private_data;
+	struct rate_info rinfo;
+	u16 rate;
+	sta_set_rate_info_tx(sta, &sta->last_tx_rate, &rinfo);
+	rate = cfg80211_calculate_bitrate(&rinfo);
+
+	return mac80211_format_buffer(userbuf, count, ppos, "%d.%d MBit/s\n",
+					rate/10, rate%10);
+
+}
+STA_OPS(current_tx_rate);
+
  #define DEBUGFS_ADD(name) \
  	debugfs_create_file(#name, 0400, \
  		sta->debugfs.dir, sta, &sta_ ##name## _ops);
@@ -369,6 +384,7 @@ void ieee80211_sta_debugfs_add(struct sta_info 
*sta)
  	DEBUGFS_ADD(dev);
  	DEBUGFS_ADD(last_signal);
  	DEBUGFS_ADD(ht_capa);
+	DEBUGFS_ADD(current_tx_rate);

  	DEBUGFS_ADD_COUNTER(rx_packets, rx_packets);
  	DEBUGFS_ADD_COUNTER(tx_packets, tx_packets);

Re: [RFC] mac80211: add debugfs file for current tx rate

[Johannes Berg]

On Mon, 2012-11-26 at 05:22 -0800, saravanad@posedge.com wrote:
> Add a debugfs file showing the current tx rate.
> The information available in the rc_stats file
> doesn't evidently provides us the current tx rate.
> This patch adds the support for the same.

I don't see any value in this, you can just do "iw station dump" to get
the information.

johannes

Re: [RFC] mac80211: add debugfs file for current tx rate

[Ben Greear]

On 11/26/2012 07:09 AM, Johannes Berg wrote:
> On Mon, 2012-11-26 at 05:22 -0800, saravanad@posedge.com wrote:
>> Add a debugfs file showing the current tx rate.
>> The information available in the rc_stats file
>> doesn't evidently provides us the current tx rate.
>> This patch adds the support for the same.
>
> I don't see any value in this, you can just do "iw station dump" to get
> the information.

Perhaps the missing bits could be added to the ethtool stats
logic...that is easily parsed on the command line and relatively
straight-forward to use programatically as well...

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com

Re: [RFC] mac80211: add debugfs file for current tx rate

[Saravana]

On 11/26/2012 08:39 PM, Johannes Berg wrote:
> On Mon, 2012-11-26 at 05:22 -0800, saravanad@posedge.com wrote:
>> Add a debugfs file showing the current tx rate.
>> The information available in the rc_stats file
>> doesn't evidently provides us the current tx rate.
>> This patch adds the support for the same.
>
> I don't see any value in this, you can just do "iw station dump" to get
> the information.
>
The debugfs already contains almost all the parameters that can be 
viewed  when "iw station dump" is used. e.g. rx/tx bytes,packets, tx 
retry, power. The current tx rate was available in iw but not in debugfs.
For sake of completeness and to maintain uniformity, thought of adding
current tx rate to debugfs.
> johannes
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

Re: [RFC] mac80211: add debugfs file for current tx rate

[Johannes Berg]

On Tue, 2012-11-27 at 11:10 +0530, Saravana wrote:
> On 11/26/2012 08:39 PM, Johannes Berg wrote:
> > On Mon, 2012-11-26 at 05:22 -0800, saravanad@posedge.com wrote:
> >> Add a debugfs file showing the current tx rate.
> >> The information available in the rc_stats file
> >> doesn't evidently provides us the current tx rate.
> >> This patch adds the support for the same.
> >
> > I don't see any value in this, you can just do "iw station dump" to get
> > the information.
> >
> The debugfs already contains almost all the parameters that can be 
> viewed  when "iw station dump" is used. e.g. rx/tx bytes,packets, tx 
> retry, power. The current tx rate was available in iw but not in debugfs.
> For sake of completeness and to maintain uniformity, thought of adding
> current tx rate to debugfs.

*shrug*
Ok, fair enough. I guess we can do that.

johannes