[RFC] mac80211: add debugfs file for last rx rate

[RFC] mac80211: add debugfs file for last rx rate

[saravanad]

Add a debugfs file showing the rate at which
the last packet is received.

Signed-off-by: Saravana <saravanad@posedge.com>
---
The diff file is generated from wireless-testing git tree.
net/mac80211/debugfs_sta.c |   16 ++++++++++++++++
  1 files changed, 16 insertions(+), 0 deletions(-)

diff --git a/net/mac80211/debugfs_sta.c b/net/mac80211/debugfs_sta.c
index 89281d2..183ca01 100644
--- a/net/mac80211/debugfs_sta.c
+++ b/net/mac80211/debugfs_sta.c
@@ -321,6 +321,21 @@ static ssize_t sta_ht_capa_read(struct file *file, 
char __user *userbuf,
  }
  STA_OPS(ht_capa);

+static ssize_t sta_last_rx_rate_read(struct file *file, char __user 
*userbuf,
+				      size_t count, loff_t *ppos)
+{
+	struct sta_info *sta = file->private_data;
+	struct rate_info rinfo;
+	u16 rate;
+
+	sta_set_rate_info_rx(sta, &rinfo);
+
+	rate = cfg80211_calculate_bitrate(&rinfo);
+
+	return mac80211_format_buffer(userbuf, count, ppos, "%d.%d MBit/s\n",
+					rate/10, rate%10);
+}
+STA_OPS(last_rx_rate);
  #define DEBUGFS_ADD(name) \
  	debugfs_create_file(#name, 0400, \
  		sta->debugfs.dir, sta, &sta_ ##name## _ops);
@@ -369,6 +384,7 @@ void ieee80211_sta_debugfs_add(struct sta_info 
*sta)
  	DEBUGFS_ADD(dev);
  	DEBUGFS_ADD(last_signal);
  	DEBUGFS_ADD(ht_capa);
+	DEBUGFS_ADD(last_rx_rate);

  	DEBUGFS_ADD_COUNTER(rx_packets, rx_packets);
  	DEBUGFS_ADD_COUNTER(tx_packets, tx_packets);

Re: [RFC] mac80211: add debugfs file for last rx rate

[Johannes Berg]

On Mon, 2012-11-26 at 05:42 -0800, saravanad@posedge.com wrote:
> Add a debugfs file showing the rate at which
> the last packet is received.

Same here, no need for a debugfs file.

johannes

Re: [RFC] mac80211: add debugfs file for last rx rate

[Saravana]

On 11/26/2012 08:40 PM, Johannes Berg wrote:
> On Mon, 2012-11-26 at 05:42 -0800, saravanad@posedge.com wrote:
>> Add a debugfs file showing the rate at which
>> the last packet is received.
>
> Same here, no need for a debugfs file.
>
As many of the statistics like rx/tx bytes/packet, tx retries, power etc
are available in debugfs,for completeness and uniformity, thought of 
adding this to debugfs.
> johannes
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
>

Re: [RFC] mac80211: add debugfs file for last rx rate

[Saravana]

On 11/27/2012 11:41 AM, Saravana wrote:
> On 11/26/2012 08:40 PM, Johannes Berg wrote:
>> On Mon, 2012-11-26 at 05:42 -0800, saravanad@posedge.com wrote:
>>> Add a debugfs file showing the rate at which
>>> the last packet is received.
>>
>> Same here, no need for a debugfs file.
>>
> As many of the statistics like rx/tx bytes/packet, tx retries, power etc
> are available in debugfs,for completeness and uniformity, thought of adding this to debugfs.
>> johannes
>>
Could last rx rate be added to debugfs?
Saravana
>> -- 
>> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
>>
> 
> -- 
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
>