From: Felix Fietkau <nbd@openwrt.org>
To: Saravana <saravanad@posedge.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: add debugfs file for last rx rate
Date: Mon, 03 Dec 2012 09:14:52 +0100 [thread overview]
Message-ID: <50BC5F7C.3080505@openwrt.org> (raw)
In-Reply-To: <50BC4453.2070705@posedge.com>
On 2012-12-03 7:18 AM, Saravana wrote:
> On 12/02/2012 06:08 PM, Felix Fietkau wrote:
>> On 2012-11-29 3:24 PM, Saravana wrote:
>>> Add a debugfs file showing the rate at which
>>> the last packet is received.
>>>
>>> Signed-off-by: Saravana <saravanad@posedge.com>
>> What's the point of adding debugfs files for data which is already
>> available via nl80211?
>>
> The debugfs is a repository of statistics. Many of the statistics like
> tx/rx bytes/packets, retries, signal,power etc which are available via nl80211(iw)
> are already available in debugfs. For the sake of completeness and to maintain
> uniformity the last rx rate is added to debugfs.
I think debugfs does not have (or need) completeness and uniformity, nor
is it meant as a repository of statistics. It is to be used for various
debugging purposes (as the name implies).
I think any additions of info to debugfs that are also available through
regular APIs should be considered unnecessary bloat and dropped.
- Felix
prev parent reply other threads:[~2012-12-03 8:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-29 14:24 [PATCH] mac80211: add debugfs file for last rx rate Saravana
2012-11-29 14:34 ` Johannes Berg
2012-11-30 7:57 ` Saravana
2012-12-02 12:38 ` Felix Fietkau
2012-12-03 6:18 ` Saravana
2012-12-03 8:14 ` Felix Fietkau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50BC5F7C.3080505@openwrt.org \
--to=nbd@openwrt.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=saravanad@posedge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).