linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* ethtool stats for wifi devices broken in 3.7.0-rc8
@ 2012-12-05  5:46 Ben Greear
  2012-12-06  9:05 ` Stanislaw Gruszka
  0 siblings, 1 reply; 2+ messages in thread
From: Ben Greear @ 2012-12-05  5:46 UTC (permalink / raw)
  To: linux-wireless@vger.kernel.org

I think the problem is that the code that assigns dev->ethtool_ops
in net/wireless/core.c checks for existence of ops first..

But, net/core/dev.c assigns a default ethtool_ops in the alloc_netdev_mqs
method.

Maybe cfg80211 should just always assign the value?

Thanks,
Ben
-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: ethtool stats for wifi devices broken in 3.7.0-rc8
  2012-12-05  5:46 ethtool stats for wifi devices broken in 3.7.0-rc8 Ben Greear
@ 2012-12-06  9:05 ` Stanislaw Gruszka
  0 siblings, 0 replies; 2+ messages in thread
From: Stanislaw Gruszka @ 2012-12-06  9:05 UTC (permalink / raw)
  To: Ben Greear; +Cc: linux-wireless@vger.kernel.org

On Tue, Dec 04, 2012 at 09:46:20PM -0800, Ben Greear wrote:
> I think the problem is that the code that assigns dev->ethtool_ops
> in net/wireless/core.c checks for existence of ops first..
> 
> But, net/core/dev.c assigns a default ethtool_ops in the alloc_netdev_mqs
> method.
> 
> Maybe cfg80211 should just always assign the value?

Care to post a patch ?

Stanislaw

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-12-06  9:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-05  5:46 ethtool stats for wifi devices broken in 3.7.0-rc8 Ben Greear
2012-12-06  9:05 ` Stanislaw Gruszka

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).