From: Saravana <saravanad@posedge.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] mac80211: add debug file for mic failure
Date: Wed, 05 Dec 2012 12:24:26 +0530 [thread overview]
Message-ID: <50BEEFA2.8000400@posedge.com> (raw)
In-Reply-To: <1354648076.9608.16.camel@jlt4.sipsolutions.net>
On 12/05/2012 12:37 AM, Johannes Berg wrote:
> On Tue, 2012-12-04 at 15:57 +0100, Johannes Berg wrote:
>> On Tue, 2012-12-04 at 19:47 +0530, Saravana wrote:
>>> The mic failure count will provide the number of mic failure that
>>> have happened without a countermeasure being started. Once the
>>> countermeasure is started, the counter will be reset to 0.
>>> This count will be helpful when the consecutive
>>> mic failure occur at intervals greater than 60 seconds regularly(frequently).
>>
>> Applied.
>
> Never mind, dropped. It has a null pointer issue and still has
could the null pointer issue be prevented by checking
the rx->key is valid before update the mic failure? Is it acceptable?
if (rx->key)
rx->key->u.tkip.mic_failures++
> whitespace issues. Please figure out how to actually indent
> parameters ...
>
The patch was verified with the checkpatch script. it didn't point out whitespace
error and the indentation issue.Is there any other scripts that needs to be run additionally?
Please let me know how to figure out this issue ?
> Also, signed-off-by should be your full name, is that really just
> "Saravana"? Your email seems to indicate there's something else
> ("saravanad")
>
My full name is Saravanakumar and my Father name is Doraiswami.
Saravanad, d-indicates my starting letter of my Father name.
I will probably use Saravanakumar in the future patches..
> johannes
>
>
next prev parent reply other threads:[~2012-12-05 6:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-04 14:17 [PATCH v2] mac80211: add debug file for mic failure Saravana
2012-12-04 14:57 ` Johannes Berg
2012-12-04 19:07 ` Johannes Berg
2012-12-05 6:54 ` Saravana [this message]
2012-12-05 8:44 ` Johannes Berg
2012-12-05 9:28 ` Saravana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50BEEFA2.8000400@posedge.com \
--to=saravanad@posedge.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).