linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chaitanya <chaitanyatk@posedge.com>
To: johannes@sipsolutions.net
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: [PATCH] mac80211: fix the multiple warnings for budding chipsets without ampdu_action defined
Date: Wed, 05 Dec 2012 17:57:39 +0530	[thread overview]
Message-ID: <50BF3DBB.90000@posedge.com> (raw)

Warn once should suffice.

Eg: our driver doesn't support the ampdu_action yet, so
seeing a lot of warnings, hence the check for any
new drivers to avoid messing the kernel log.

Changed the mail client to thunder bird to avoid whitespace issues.
Changed the subject and also the signing off to use offical mail.

Signed-off-by: T Krushna Chaitanya <chaitanyatk@posedge.com>
---
net/mac80211/agg-tx.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/mac80211/agg-tx.c b/net/mac80211/agg-tx.c
index 4152ed1..eb9df22 100644
--- a/net/mac80211/agg-tx.c
+++ b/net/mac80211/agg-tx.c
@@ -445,7 +445,7 @@ int ieee80211_start_tx_ba_session(struct ieee80211_sta *pubsta, u16 tid,
 
     trace_api_start_tx_ba_session(pubsta, tid);
 
-    if (WARN_ON(!local->ops->ampdu_action))
+    if (WARN_ON_ONCE(!local->ops->ampdu_action))
         return -EINVAL;
 
     if ((tid >= IEEE80211_NUM_TIDS) ||

             reply	other threads:[~2012-12-05 12:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-05 12:27 Chaitanya [this message]
2012-12-05 12:30 ` [PATCH] mac80211: fix the multiple warnings for budding chipsets without ampdu_action defined Johannes Berg
2012-12-05 12:32   ` Chaitanya
  -- strict thread matches above, loose matches on Subject: below --
2012-12-06  8:16 Chaitanya
2012-12-06  8:51 ` Stanislaw Gruszka
2012-12-06  9:37   ` Chaitanya
2012-12-06 10:40     ` Johannes Berg
     [not found] <201212070645.qB76jSjN013395@chaitanya-desktop>
2012-12-07  6:49 ` Chaitanya
2012-12-07  8:14   ` Johannes Berg
2012-12-07  9:29     ` Chaitanya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50BF3DBB.90000@posedge.com \
    --to=chaitanyatk@posedge.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).