From: Ben Greear <greearb@candelatech.com>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: "Bjørn Mork" <bjorn@mork.no>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] wireless: Fix ethtool stats and other ops.
Date: Thu, 06 Dec 2012 12:15:28 -0800 [thread overview]
Message-ID: <50C0FCE0.2090507@candelatech.com> (raw)
In-Reply-To: <20121206122528.GG2502@redhat.com>
On 12/06/2012 04:25 AM, Stanislaw Gruszka wrote:
>>> Won't this break drivers which for some reason have their own
>>> ethtool_ops?
>>
>> I guess it will. What a mess.
>>
>> Maybe we could assign individual method pointers in the ethtool_ops
>> struct if it already exists (and if those pointers are NULL)?
>
> We should probably assing ethtool_ops before wireless core will
> call alloc_netdev.
>
> Stanislaw
>
I don't have time to work on this today...maybe not tomorrow either.
So, if someone else feels like fixing it, please feel free.
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2012-12-06 20:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-05 17:39 [PATCH] wireless: Fix ethtool stats and other ops greearb
2012-12-05 17:57 ` Bjørn Mork
2012-12-05 18:02 ` Ben Greear
2012-12-06 12:25 ` Stanislaw Gruszka
2012-12-06 15:22 ` Vladimir Kondratiev
2012-12-06 20:15 ` Ben Greear [this message]
2012-12-07 9:50 ` Stanislaw Gruszka
2012-12-07 11:30 ` Bjørn Mork
2012-12-07 11:40 ` Stanislaw Gruszka
2012-12-07 12:16 ` [RFC] wireless: check against default_ethtool_ops Stanislaw Gruszka
2012-12-07 16:27 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C0FCE0.2090507@candelatech.com \
--to=greearb@candelatech.com \
--cc=bjorn@mork.no \
--cc=linux-wireless@vger.kernel.org \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).