From: "\"David Müller (ELSOFT AG)\"" <d.mueller@elsoft.ch>
To: Stanislaw Gruszka <stf_xl@wp.pl>
Cc: linux-wireless@vger.kernel.org, users@rt2x00.serialmonkey.com
Subject: Re: [rt2x00-users] [PATCH] rt2800: refactor RFCSR initialization
Date: Wed, 12 Dec 2012 09:00:24 +0100 [thread overview]
Message-ID: <50C83998.4020508@elsoft.ch> (raw)
In-Reply-To: <20121212053054.GA4356@localhost.localdomain>
Hi
Stanislaw Gruszka wrote:
> +static void rt2800_init_rfcsr_305x_soc(struct rt2x00_dev *rt2x00dev)
> +{
> + rt2800_rfcsr_write(rt2x00dev, 0, 0x50);
> + rt2800_rfcsr_write(rt2x00dev, 1, 0x01);
> + rt2800_rfcsr_write(rt2x00dev, 2, 0xf7);
> + rt2800_rfcsr_write(rt2x00dev, 3, 0x75);
> + rt2800_rfcsr_write(rt2x00dev, 4, 0x40);
> + rt2800_rfcsr_write(rt2x00dev, 5, 0x03);
> + rt2800_rfcsr_write(rt2x00dev, 6, 0x02);
> + rt2800_rfcsr_write(rt2x00dev, 7, 0x50);
Wouldn't a table based initialization be more readable and also shorter?
Dave
next prev parent reply other threads:[~2012-12-12 8:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-12 5:30 [PATCH] rt2800: refactor RFCSR initialization Stanislaw Gruszka
2012-12-12 8:00 ` "David Müller (ELSOFT AG)" [this message]
2012-12-12 16:19 ` [rt2x00-users] " Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C83998.4020508@elsoft.ch \
--to=d.mueller@elsoft.ch \
--cc=linux-wireless@vger.kernel.org \
--cc=stf_xl@wp.pl \
--cc=users@rt2x00.serialmonkey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).