From: Gabor Juhos <juhosg@openwrt.org>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: Daniel Golle <dgolle@allnet.de>,
linux-wireless@vger.kernel.org, users@rt2x00.serialmonkey.com,
helmut.schaa@googlemail.com, gwingerde@gmail.com,
john@phrozen.org
Subject: Re: [PATCH 1/3] rt2x00: allow overriding eeprom through platform_data
Date: Wed, 12 Dec 2012 20:12:05 +0100 [thread overview]
Message-ID: <50C8D705.3090304@openwrt.org> (raw)
In-Reply-To: <20121212073627.GB2253@redhat.com>
2012.12.12. 8:36 keltezéssel, Stanislaw Gruszka írta:
> Hi
>
> I have one additional question:
>
> On Tue, Dec 11, 2012 at 12:03:53PM +0200, Daniel Golle wrote:
>> + if (rt2x00_is_soc(rt2x00dev) ||
>> + test_bit(REQUIRE_EEPROM_FILE, &rt2x00dev->cap_flags))
>> + rt2800pci_read_eeprom_file(rt2x00dev);
> Is || correct here ?
There are various embedded boards where a Ralink WiFi chip is soldered directly
onto the PCB and that does not have a separate EEPROM. The EEPROM data is stored
in the main flash of the board. The '||' allows to load the EEPROM data via
firmware API for such PCI devices as well.
However, the condition can be simplified. The REQUIRE_EEPROM_FILE bit is always
set for SoC devices, so the 'rt2x00_is_soc(rt2x00dev) ||' part is superfluous.
Given the fact that the patch must be reworked, this part will go away anyway
probably.
-Gabor
prev parent reply other threads:[~2012-12-12 19:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-11 10:03 [PATCH 1/3] rt2x00: allow overriding eeprom through platform_data Daniel Golle
2012-12-11 21:40 ` Gertjan van Wingerde
2012-12-12 19:09 ` Gabor Juhos
2012-12-12 7:36 ` Stanislaw Gruszka
2012-12-12 19:12 ` Gabor Juhos [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C8D705.3090304@openwrt.org \
--to=juhosg@openwrt.org \
--cc=dgolle@allnet.de \
--cc=gwingerde@gmail.com \
--cc=helmut.schaa@googlemail.com \
--cc=john@phrozen.org \
--cc=linux-wireless@vger.kernel.org \
--cc=sgruszka@redhat.com \
--cc=users@rt2x00.serialmonkey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).