From: Ben Greear <greearb@candelatech.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC 2/6] wifi: Don't spam logs with 'Found new beacon' messages.
Date: Wed, 12 Dec 2012 14:15:24 -0800 [thread overview]
Message-ID: <50C901FC.3040306@candelatech.com> (raw)
In-Reply-To: <1355350115.9708.21.camel@jlt4.sipsolutions.net>
On 12/12/2012 02:08 PM, Johannes Berg wrote:
> On Wed, 2012-12-12 at 13:54 -0800, greearb@candelatech.com wrote:
>> From: Ben Greear <greearb@candelatech.com>
>>
>> We saw logs fill with this (at very high speeds):
>>
>> cfg80211: Found new beacon on frequency: 5745 MHz (Ch 149) on wiphy0
>> cfg80211: Found new beacon on frequency: 5745 MHz (Ch 149) on wiphy0
>> cfg80211: Found new beacon on frequency: 5745 MHz (Ch 149) on wiphy0
>> cfg80211: Found new beacon on frequency: 5745 MHz (Ch 149) on wiphy0
>> cfg80211: Found new beacon on frequency: 5745 MHz (Ch 149) on wiphy0
>> cfg80211: Found new beacon on frequency: 5745 MHz (Ch 149) on wiphy0
>> cfg80211: Found new beacon on frequency: 5745 MHz (Ch 149) on wiphy0
>> cfg80211: Found new beacon on frequency: 5745 MHz (Ch 149) on wiphy0
>> cfg80211: Found new beacon on frequency: 5745 MHz (Ch 149) on wiphy0
>> cfg80211: Found new beacon on frequency: 5745 MHz (Ch 149) on wiphy0
>> cfg80211: Found new beacon on frequency: 5745 MHz (Ch 149) on wiphy0
>> cfg80211: Found new beacon on frequency: 5745 MHz (Ch 149) on wiphy0
>>
>> Signed-off-by: Ben Greear <greearb@candelatech.com>
>> ---
>> net/wireless/reg.c | 11 ++++++-----
>> 1 files changed, 6 insertions(+), 5 deletions(-)
>>
>> diff --git a/net/wireless/reg.c b/net/wireless/reg.c
>> index 6e53089..8aa7867 100644
>> --- a/net/wireless/reg.c
>> +++ b/net/wireless/reg.c
>> @@ -2067,11 +2067,12 @@ int regulatory_hint_found_beacon(struct wiphy *wiphy,
>> if (!reg_beacon)
>> return -ENOMEM;
>>
>> - REG_DBG_PRINT("Found new beacon on "
>
> Why not just disable the config option for it if you don't care?
I don't mind seeing it, just don't want thousands of them in my logs
in a very short amount of time. Maybe I was just hitting some
other bug, and there is no valid reason for this to ever spam?
Thanks,
Ben
>
> johannes
>
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2012-12-12 22:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-12 21:54 [RFC 1/6] ath9k: Report txerr-filtered errors in debugfs greearb
2012-12-12 21:54 ` [RFC 2/6] wifi: Don't spam logs with 'Found new beacon' messages greearb
2012-12-12 22:08 ` Johannes Berg
2012-12-12 22:15 ` Ben Greear [this message]
2012-12-12 22:17 ` Johannes Berg
2012-12-12 22:20 ` Johannes Berg
2012-12-12 22:24 ` Johannes Berg
2012-12-13 20:31 ` Luis R. Rodriguez
2012-12-12 21:54 ` [RFC 3/6] mac80211: Check for NULL in get-ethtool-stats logic greearb
2012-12-12 22:02 ` Johannes Berg
2012-12-12 22:11 ` Ben Greear
2012-12-12 21:54 ` [RFC 4/6] mac80211: Allow disabling SGI-20 greearb
2012-12-12 22:06 ` Johannes Berg
2012-12-12 22:08 ` Ben Greear
2012-12-13 0:58 ` Ben Greear
2012-12-12 21:54 ` [RFC 5/6] ath9k: Report rx-crc-errors in ethtool stats greearb
2012-12-12 21:54 ` [RFC 6/6] ath9k: Allow using ath9k-rate-control without forcing it greearb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C901FC.3040306@candelatech.com \
--to=greearb@candelatech.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).