From: Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: <linville@tuxdriver.com>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 2/2] cfg80211/nl80211: Enable drivers to implement mac address based ACL
Date: Thu, 13 Dec 2012 10:26:30 +0530 [thread overview]
Message-ID: <50C95FFE.2040200@qca.qualcomm.com> (raw)
In-Reply-To: <1355311635.9708.3.camel@jlt4.sipsolutions.net>
On Wednesday 12 December 2012 04:57 PM, Johannes Berg wrote:
> On Wed, 2012-12-12 at 12:26 +0100, Johannes Berg wrote:
>
>> Yeah but I don't think that's a valid general assumption, and with the
>> feature advertising API that you came up with, the driver can't
>> advertise that it supports both at the same time etc.
>>
>> Also, in fact, I think there needs to be more justification for why you
>> need two lists to start with -- it seems to me that a white- and
>> blacklist doesn't make sense at all, unless it's not really a white- and
>> blacklist but one of
>> 1) a blacklist
>> 2) a whitelist + a "do not notify" list
>
> And actually, without a notify mechanism (which I don't think exists
> yet) this doesn't make sense anyway
We have it for a connection request from a client listed under
black list through NL80211_ATTR_CONN_FAILED_REASON in
NL80211_CMD_CONN_FAILED. But the one which needs to be
there for a connection from client which is part of
neither of the groups is not yet there. As I mentioned
in my previous reply, is this also be sent in
NL80211_CMD_CONN_FAILED.
Vasanth
next prev parent reply other threads:[~2012-12-13 4:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-07 11:46 [PATCH 1/2] cfg80211: Move the definition of struct mac_address up Vasanthakumar Thiagarajan
2012-12-07 11:46 ` [PATCH 2/2] cfg80211/nl80211: Enable drivers to implement mac address based ACL Vasanthakumar Thiagarajan
2012-12-11 19:57 ` Johannes Berg
2012-12-12 5:16 ` Vasanthakumar Thiagarajan
2012-12-12 11:26 ` Johannes Berg
2012-12-12 11:27 ` Johannes Berg
2012-12-13 4:56 ` Vasanthakumar Thiagarajan [this message]
2012-12-13 4:52 ` Vasanthakumar Thiagarajan
2012-12-13 5:47 ` Sujith Manoharan
2012-12-13 5:56 ` Vasanthakumar Thiagarajan
2012-12-12 10:14 ` Antonio Quartulli
2012-12-12 11:07 ` Vasanthakumar Thiagarajan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C95FFE.2040200@qca.qualcomm.com \
--to=vthiagar@qca.qualcomm.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).