From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.candelatech.com ([208.74.158.172]:32988 "EHLO ns3.lanforge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753028Ab2LMTRT (ORCPT ); Thu, 13 Dec 2012 14:17:19 -0500 Message-ID: <50CA29BB.8080104@candelatech.com> (sfid-20121213_201723_614964_9EC30FC6) Date: Thu, 13 Dec 2012 11:17:15 -0800 From: Ben Greear MIME-Version: 1.0 To: Johannes Berg CC: "linux-wireless@vger.kernel.org" Subject: Re: Add a new work-queue for destructing stations? References: <50CA1470.4030107@candelatech.com> (sfid-20121213_184629_945929_240FAE82) <1355421541.9463.8.camel@jlt4.sipsolutions.net> <50CA1C44.5030300@candelatech.com> <1355423047.9463.9.camel@jlt4.sipsolutions.net> <50CA1EB6.9030903@candelatech.com> <1355423836.9463.14.camel@jlt4.sipsolutions.net> <50CA20D4.90707@candelatech.com> <1355424117.9463.16.camel@jlt4.sipsolutions.net> <50CA22BC.7090008@candelatech.com> <1355424597.9463.17.camel@jlt4.sipsolutions.net> (sfid-20121213_194937_732132_61453C42) <1355424835.9463.18.camel@jlt4.sipsolutions.net> <50CA25B1.3080901@candelatech.com> <1355425884.9463.19.camel@jlt4.sipsolutions.net> In-Reply-To: <1355425884.9463.19.camel@jlt4.sipsolutions.net> Content-Type: text/plain; charset=UTF-8; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 12/13/2012 11:11 AM, Johannes Berg wrote: > On Thu, 2012-12-13 at 11:00 -0800, Ben Greear wrote: >> On 12/13/2012 10:53 AM, Johannes Berg wrote: >>> On Thu, 2012-12-13 at 19:49 +0100, Johannes Berg wrote: >>> >>>>>> Well the concern there is that we expose the workqueue to the driver, >>>>>> and it might even put sdata-referencing work items on it and expect them >>>>>> to be flushed out before stop_interface() is called? >>> >>> Wait actually, that isn't a concern. The flush_workqueue() was new in >>> commit b22cfcfca, before that drivers couldn't rely on it. It seems very >>> unlikely that in the meantime drivers have come to rely on it and we >>> didn't document this, so ... with the proposed change to sta_free_wk we >>> should be fine. >> >> We still need to cancel the other mac80211 work items though, right? > > Well, no, because we didn't add any work items since we added the > flush_workqueue() there. > >> I didn't understand your proposal for the sta_free_wk changes, >> but I can at least work on tracking down the mac80211 work items >> if that helps... > > I'll get a patch out later or tomorrow. Ok, I'll be sure to test it, and will hold off on any of my own efforts in this area in the meantime. Thanks, Ben > > johannes > -- Ben Greear Candela Technologies Inc http://www.candelatech.com