linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, Eliad Peller <eliad@wizery.com>
Subject: Re: [PATCH 0/5] mac80211: fix station cleanup/destruction
Date: Fri, 14 Dec 2012 10:08:29 -0800	[thread overview]
Message-ID: <50CB6B1D.4050409@candelatech.com> (raw)
In-Reply-To: <1355439573-13206-1-git-send-email-johannes@sipsolutions.net>

On 12/13/2012 02:59 PM, Johannes Berg wrote:
> Turns out that not only was flush_workqueue() slow as reported
> by Ben, it was also broken because this is way too late to
> finish the station destruction in AP mode.
>
> Fixing this with keeping the roaming semantics (no RCU barrier
> or synchronize in there) is a bit tricky so the first patch just
> fixes the problem, and the last patch puts back the optimisation.
>
> The patches inbetween are just padding ;-)

I applied this series (as well as the beacon cleanup from Luius)
and so far, the 600-station test case is working fine.

I backported this to 3.7.0, by the way.  It was mostly clean,
but I had to tweak a few things to resolve conflicts.

We will of course let you know if we see anything weird :)

So, you can add:

Tested-by:  Ben Greear <greearb@candelatech.com>


Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


  parent reply	other threads:[~2012-12-14 18:08 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-13 22:59 [PATCH 0/5] mac80211: fix station cleanup/destruction Johannes Berg
2012-12-13 22:59 ` [PATCH 1/5] mac80211: fix station destruction in AP/mesh modes Johannes Berg
2012-12-13 22:59 ` [PATCH 2/5] mac80211: use del_timer_sync for final sta cleanup timer deletion Johannes Berg
2012-12-13 23:26   ` Johannes Berg
2012-12-13 22:59 ` [PATCH 3/5] mac80211: remove final sta_info_flush() Johannes Berg
2012-12-13 22:59 ` [PATCH 4/5] mac80211: warn if unexpectedly removing stations Johannes Berg
2012-12-13 22:59 ` [PATCH 5/5] mac80211: optimise roaming time again Johannes Berg
2012-12-13 23:32   ` Eliad Peller
2012-12-13 23:41     ` Johannes Berg
2012-12-13 23:57       ` Eliad Peller
2012-12-14  8:33         ` Johannes Berg
2012-12-14 13:57 ` [PATCH] mac80211: optimise AP stop RCU handling Johannes Berg
2012-12-20 11:16   ` Johannes Berg
2012-12-14 18:08 ` Ben Greear [this message]
2012-12-20 11:12 ` [PATCH 0/5] mac80211: fix station cleanup/destruction Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50CB6B1D.4050409@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=eliad@wizery.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).