From: Larry Finger <Larry.Finger@lwfinger.net>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: linville@tuxdriver.com, davem@davemloft.net,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] forcedeth: Fix WARNINGS that result when DMA mapping is not checked
Date: Thu, 27 Dec 2012 14:38:49 -0600 [thread overview]
Message-ID: <50DCB1D9.50906@lwfinger.net> (raw)
In-Reply-To: <1356638715.30414.1349.camel@edumazet-glaptop>
On 12/27/2012 02:05 PM, Eric Dumazet wrote:
> On Thu, 2012-12-27 at 13:42 -0600, Larry Finger wrote:
>> With 3.8-rc1, the first call of pci_map_single() that is not checked
>> with a corresponding pci_dma_mapping_error() call results in a warning
>> with a splat as follows:
>>
>> WARNING: at lib/dma-debug.c:933 check_unmap+0x480/0x950()
>> Hardware name: HP Pavilion dv2700 Notebook PC
>> forcedeth 0000:00:0a.0: DMA-API: device driver failed to check
>> map error[device address=0x00000000b176e002] [size=90 bytes] [mapped as single]
>>
>> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
>> ---
>> drivers/net/ethernet/nvidia/forcedeth.c | 23 +++++++++++++++++++++++
>> 1 file changed, 23 insertions(+)
>>
>> diff --git a/drivers/net/ethernet/nvidia/forcedeth.c b/drivers/net/ethernet/nvidia/forcedeth.c
>> index 653487d..de39cf2 100644
>> --- a/drivers/net/ethernet/nvidia/forcedeth.c
>> +++ b/drivers/net/ethernet/nvidia/forcedeth.c
>> @@ -1821,6 +1821,11 @@ static int nv_alloc_rx(struct net_device *dev)
>> skb->data,
>> skb_tailroom(skb),
>> PCI_DMA_FROMDEVICE);
>> + if (pci_dma_mapping_error(np->pci_dev,
>> + np->put_rx_ctx->dma)) {
>> + dev_kfree_skb_any(skb);
>
> skb has no destructor yet, kfree_skb(skb) should be fine
OK.
>
>> + goto packet_dropped;
>> + }
>> np->put_rx_ctx->dma_len = skb_tailroom(skb);
>> np->put_rx.orig->buf = cpu_to_le32(np->put_rx_ctx->dma);
>> wmb();
>> @@ -1830,6 +1835,7 @@ static int nv_alloc_rx(struct net_device *dev)
>> if (unlikely(np->put_rx_ctx++ == np->last_rx_ctx))
>> np->put_rx_ctx = np->first_rx_ctx;
>> } else {
>> +packet_dropped:
>> u64_stats_update_begin(&np->swstats_rx_syncp);
>> np->stat_rx_dropped++;
>> u64_stats_update_end(&np->swstats_rx_syncp);
>> @@ -1856,6 +1862,11 @@ static int nv_alloc_rx_optimized(struct net_device *dev)
>> skb->data,
>> skb_tailroom(skb),
>> PCI_DMA_FROMDEVICE);
>> + if (pci_dma_mapping_error(np->pci_dev,
>> + np->put_rx_ctx->dma)) {
>> + dev_kfree_skb_any(skb);
>> + goto packet_dropped;
>> + }
>> np->put_rx_ctx->dma_len = skb_tailroom(skb);
>> np->put_rx.ex->bufhigh = cpu_to_le32(dma_high(np->put_rx_ctx->dma));
>> np->put_rx.ex->buflow = cpu_to_le32(dma_low(np->put_rx_ctx->dma));
>> @@ -1866,6 +1877,7 @@ static int nv_alloc_rx_optimized(struct net_device *dev)
>> if (unlikely(np->put_rx_ctx++ == np->last_rx_ctx))
>> np->put_rx_ctx = np->first_rx_ctx;
>> } else {
>> +packet_dropped:
>> u64_stats_update_begin(&np->swstats_rx_syncp);
>> np->stat_rx_dropped++;
>> u64_stats_update_end(&np->swstats_rx_syncp);
>> @@ -2217,6 +2229,9 @@ static netdev_tx_t nv_start_xmit(struct sk_buff *skb, struct net_device *dev)
>> bcnt = (size > NV_TX2_TSO_MAX_SIZE) ? NV_TX2_TSO_MAX_SIZE : size;
>> np->put_tx_ctx->dma = pci_map_single(np->pci_dev, skb->data + offset, bcnt,
>> PCI_DMA_TODEVICE);
>> + if (pci_dma_mapping_error(np->pci_dev,
>> + np->put_tx_ctx->dma))
>> + return NETDEV_TX_BUSY;
>
> Really this is not going to work very well : caller will call this in a
> loop.
Any suggestions on what value should be returned, or does the caller need to be
modified?
Thanks for the review,
Larry
next prev parent reply other threads:[~2012-12-27 20:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-27 19:42 [PATCH] forcedeth: Fix WARNINGS that result when DMA mapping is not checked Larry Finger
2012-12-27 20:05 ` Eric Dumazet
2012-12-27 20:38 ` Larry Finger [this message]
2012-12-27 21:03 ` Eric Dumazet
2012-12-27 21:32 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50DCB1D9.50906@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).