linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Arend van Spriel" <arend@broadcom.com>
To: "Linus Torvalds" <torvalds@linux-foundation.org>
Cc: "Brett Rudley" <brudley@broadcom.com>,
	"Franky (Zhenhui) Lin" <frankyl@broadcom.com>,
	"Hante Meuleman" <meuleman@broadcom.com>,
	"John W. Linville" <linville@tuxdriver.com>,
	"Linux Wireless List" <linux-wireless@vger.kernel.org>,
	brcm80211-dev-list@broadcom.com,
	"Seth Forshee" <seth.forshee@canonical.com>
Subject: Re: WARNING: at drivers/net/wireless/brcm80211/brcmsmac/main.c:7539
Date: Wed, 2 Jan 2013 13:05:49 +0100	[thread overview]
Message-ID: <50E4229D.5000900@broadcom.com> (raw)
In-Reply-To: <CA+55aFwpdyrtvE=86e1aHE9L5TR+_xP7e4PBBKtdcey3=f+Suw@mail.gmail.com>

On 12/28/2012 07:07 AM, Linus Torvalds wrote:
> Ok, maybe somebody is interested in this.. I don't know what triggered
> it, but maybe the few lines around it give some clue.

Hi Linus,

I am interested (being paid for it kinda helps). The warning itself does
not necessarily have to be a problem, but the frameid mismatch between
tx status info and the related buffer taken from the DMA ring does.
Smells like a race condition, but I need to investigate that.

> I think it's new to 3.8-rc1, because I haven't seen it before (well,
> I'm running current -git - v3.8.0-rc1-00035-g101e5c7470eb to be exact
> - but the networking changes since -rc1 are small and seem unrelated).
> But maybe it just happens under certain circumstances.

We had a big contribution from Canonical (cc-ed Seth) in brcmsmac
itself. Not playing the blame game, but I suspect it has altered
circumstances making the real issue (that was already there) more likely
to happen. Hope that helps us nailing it down.

>                     Linus
> 

Regards,
Arend

> ---
> [  573.596631] brcmsmac bcma0:0: brcms_ops_bss_info_changed: arp
> filtering: enabled true, count 1 (implement)
> [  584.154535] brcmsmac bcma0:0: brcms_c_ampdu_dotxstatus_complete:
> Pkt tx suppressed, illegal channel possibly 1
> [  584.154628] brcmsmac bcma0:0: brcms_c_ampdu_dotxstatus_complete:
> Pkt tx suppressed, illegal channel possibly 1
> [  584.925487] ------------[ cut here ]------------
> [  584.925521] WARNING: at
> drivers/net/wireless/brcm80211/brcmsmac/main.c:7539
> brcms_c_wait_for_tx_completion+0xa3/0xc0 [brcmsmac]()



  reply	other threads:[~2013-01-02 12:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-28  6:07 WARNING: at drivers/net/wireless/brcm80211/brcmsmac/main.c:7539 Linus Torvalds
2013-01-02 12:05 ` Arend van Spriel [this message]
2013-01-02 13:50   ` Seth Forshee
2013-01-02 14:08     ` Arend van Spriel
2013-01-02 15:09       ` Seth Forshee
2013-01-02 20:48         ` Arend van Spriel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50E4229D.5000900@broadcom.com \
    --to=arend@broadcom.com \
    --cc=brcm80211-dev-list@broadcom.com \
    --cc=brudley@broadcom.com \
    --cc=frankyl@broadcom.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=meuleman@broadcom.com \
    --cc=seth.forshee@canonical.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).