* WARNING: at drivers/net/wireless/brcm80211/brcmsmac/main.c:7539
@ 2012-12-28 6:07 Linus Torvalds
2013-01-02 12:05 ` Arend van Spriel
0 siblings, 1 reply; 6+ messages in thread
From: Linus Torvalds @ 2012-12-28 6:07 UTC (permalink / raw)
To: Brett Rudley, Arend van Spriel, Franky (Zhenhui) Lin,
Hante Meuleman, John W. Linville
Cc: Linux Wireless List, brcm80211-dev-list
Ok, maybe somebody is interested in this.. I don't know what triggered
it, but maybe the few lines around it give some clue.
I think it's new to 3.8-rc1, because I haven't seen it before (well,
I'm running current -git - v3.8.0-rc1-00035-g101e5c7470eb to be exact
- but the networking changes since -rc1 are small and seem unrelated).
But maybe it just happens under certain circumstances.
Linus
---
[ 573.596631] brcmsmac bcma0:0: brcms_ops_bss_info_changed: arp
filtering: enabled true, count 1 (implement)
[ 584.154535] brcmsmac bcma0:0: brcms_c_ampdu_dotxstatus_complete:
Pkt tx suppressed, illegal channel possibly 1
[ 584.154628] brcmsmac bcma0:0: brcms_c_ampdu_dotxstatus_complete:
Pkt tx suppressed, illegal channel possibly 1
[ 584.925487] ------------[ cut here ]------------
[ 584.925521] WARNING: at
drivers/net/wireless/brcm80211/brcmsmac/main.c:7539
brcms_c_wait_for_tx_completion+0xa3/0xc0 [brcmsmac]()
[ 584.925525] Hardware name: MacBookAir4,1
[ 584.925527] Modules linked in: brcmsmac brcmutil bcma
[ 584.925541] Pid: 4312, comm: kworker/u:9 Not tainted
3.8.0-rc1-00035-g101e5c7470eb #4
[ 584.925544] Call Trace:
[ 584.925558] [<ffffffff8104308a>] warn_slowpath_common+0x7a/0xb0
[ 584.925565] [<ffffffff810430d5>] warn_slowpath_null+0x15/0x20
[ 584.925584] [<ffffffffa0024b03>]
brcms_c_wait_for_tx_completion+0xa3/0xc0 [brcmsmac]
[ 584.925597] [<ffffffffa00181b6>] brcms_ops_flush+0x36/0x50 [brcmsmac]
[ 584.925608] [<ffffffff81785b3d>] ieee80211_scan_work+0x18d/0x520
[ 584.925636] [<ffffffff8105bc19>] process_one_work+0x129/0x480
[ 584.925651] [<ffffffff8105c345>] worker_thread+0x155/0x3f0
[ 584.925674] [<ffffffff8106097b>] kthread+0xbb/0xc0
[ 584.925690] [<ffffffff817c68ec>] ret_from_fork+0x7c/0xb0
[ 584.925698] [<ffffffff810608c0>] ? kthread_freezable_should_stop+0x60/0x60
[ 584.925703] ---[ end trace eeea7613ef80ba9b ]---
[ 588.284074] brcmsmac bcma0:0: frameid != txh->TxFrameID
[ 588.284098] brcmsmac bcma0:0: MI_TFS: fatal
[ 588.284103] brcmsmac bcma0:0: wl0: fatal error, reinitializing
[ 588.286208] ieee80211 phy0: Hardware restart was requested
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: WARNING: at drivers/net/wireless/brcm80211/brcmsmac/main.c:7539 2012-12-28 6:07 WARNING: at drivers/net/wireless/brcm80211/brcmsmac/main.c:7539 Linus Torvalds @ 2013-01-02 12:05 ` Arend van Spriel 2013-01-02 13:50 ` Seth Forshee 0 siblings, 1 reply; 6+ messages in thread From: Arend van Spriel @ 2013-01-02 12:05 UTC (permalink / raw) To: Linus Torvalds Cc: Brett Rudley, Franky (Zhenhui) Lin, Hante Meuleman, John W. Linville, Linux Wireless List, brcm80211-dev-list, Seth Forshee On 12/28/2012 07:07 AM, Linus Torvalds wrote: > Ok, maybe somebody is interested in this.. I don't know what triggered > it, but maybe the few lines around it give some clue. Hi Linus, I am interested (being paid for it kinda helps). The warning itself does not necessarily have to be a problem, but the frameid mismatch between tx status info and the related buffer taken from the DMA ring does. Smells like a race condition, but I need to investigate that. > I think it's new to 3.8-rc1, because I haven't seen it before (well, > I'm running current -git - v3.8.0-rc1-00035-g101e5c7470eb to be exact > - but the networking changes since -rc1 are small and seem unrelated). > But maybe it just happens under certain circumstances. We had a big contribution from Canonical (cc-ed Seth) in brcmsmac itself. Not playing the blame game, but I suspect it has altered circumstances making the real issue (that was already there) more likely to happen. Hope that helps us nailing it down. > Linus > Regards, Arend > --- > [ 573.596631] brcmsmac bcma0:0: brcms_ops_bss_info_changed: arp > filtering: enabled true, count 1 (implement) > [ 584.154535] brcmsmac bcma0:0: brcms_c_ampdu_dotxstatus_complete: > Pkt tx suppressed, illegal channel possibly 1 > [ 584.154628] brcmsmac bcma0:0: brcms_c_ampdu_dotxstatus_complete: > Pkt tx suppressed, illegal channel possibly 1 > [ 584.925487] ------------[ cut here ]------------ > [ 584.925521] WARNING: at > drivers/net/wireless/brcm80211/brcmsmac/main.c:7539 > brcms_c_wait_for_tx_completion+0xa3/0xc0 [brcmsmac]() ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: WARNING: at drivers/net/wireless/brcm80211/brcmsmac/main.c:7539 2013-01-02 12:05 ` Arend van Spriel @ 2013-01-02 13:50 ` Seth Forshee 2013-01-02 14:08 ` Arend van Spriel 0 siblings, 1 reply; 6+ messages in thread From: Seth Forshee @ 2013-01-02 13:50 UTC (permalink / raw) To: Arend van Spriel Cc: Linus Torvalds, Brett Rudley, Franky (Zhenhui) Lin, Hante Meuleman, John W. Linville, Linux Wireless List, brcm80211-dev-list On Wed, Jan 02, 2013 at 01:05:49PM +0100, Arend van Spriel wrote: > On 12/28/2012 07:07 AM, Linus Torvalds wrote: > > Ok, maybe somebody is interested in this.. I don't know what triggered > > it, but maybe the few lines around it give some clue. > > Hi Linus, > > I am interested (being paid for it kinda helps). The warning itself does > not necessarily have to be a problem, but the frameid mismatch between > tx status info and the related buffer taken from the DMA ring does. > Smells like a race condition, but I need to investigate that. > > > I think it's new to 3.8-rc1, because I haven't seen it before (well, > > I'm running current -git - v3.8.0-rc1-00035-g101e5c7470eb to be exact > > - but the networking changes since -rc1 are small and seem unrelated). > > But maybe it just happens under certain circumstances. > > We had a big contribution from Canonical (cc-ed Seth) in brcmsmac > itself. Not playing the blame game, but I suspect it has altered > circumstances making the real issue (that was already there) more likely > to happen. Hope that helps us nailing it down. I'm certain that both problems existed prior to 3.8-rc1. The warning itself has generated a fairly consistent trickle of bug reports for a while now. I haven't noticed any increased frequency of these messages; if anything I'd say I'm hitting the WARN_ON less often (though I've been doing a lot of testing under heavy load so my observations may not be typical). The channel mismatch errors are something I plan to look into, but I've been distracted by some background scanning problems (not specific to brcmsmac). Seth ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: WARNING: at drivers/net/wireless/brcm80211/brcmsmac/main.c:7539 2013-01-02 13:50 ` Seth Forshee @ 2013-01-02 14:08 ` Arend van Spriel 2013-01-02 15:09 ` Seth Forshee 0 siblings, 1 reply; 6+ messages in thread From: Arend van Spriel @ 2013-01-02 14:08 UTC (permalink / raw) To: Seth Forshee Cc: Linus Torvalds, Brett Rudley, Franky (Zhenhui) Lin, Hante Meuleman, John W. Linville, Linux Wireless List, brcm80211-dev-list On 01/02/2013 02:50 PM, Seth Forshee wrote: > On Wed, Jan 02, 2013 at 01:05:49PM +0100, Arend van Spriel wrote: >> On 12/28/2012 07:07 AM, Linus Torvalds wrote: >>> Ok, maybe somebody is interested in this.. I don't know what triggered >>> it, but maybe the few lines around it give some clue. >> >> Hi Linus, >> >> I am interested (being paid for it kinda helps). The warning itself does >> not necessarily have to be a problem, but the frameid mismatch between >> tx status info and the related buffer taken from the DMA ring does. >> Smells like a race condition, but I need to investigate that. >> >>> I think it's new to 3.8-rc1, because I haven't seen it before (well, >>> I'm running current -git - v3.8.0-rc1-00035-g101e5c7470eb to be exact >>> - but the networking changes since -rc1 are small and seem unrelated). >>> But maybe it just happens under certain circumstances. >> >> We had a big contribution from Canonical (cc-ed Seth) in brcmsmac >> itself. Not playing the blame game, but I suspect it has altered >> circumstances making the real issue (that was already there) more likely >> to happen. Hope that helps us nailing it down. > > I'm certain that both problems existed prior to 3.8-rc1. The warning > itself has generated a fairly consistent trickle of bug reports for a > while now. I haven't noticed any increased frequency of these messages; > if anything I'd say I'm hitting the WARN_ON less often (though I've been > doing a lot of testing under heavy load so my observations may not be > typical). Hi Seth, Indeed the warning has been there for a while, but the fatal error resulting in triggering a restart from mac80211 has popped up late in the 3.7-rc cycles and seem to consistently fail on our smoketest as well. > The channel mismatch errors are something I plan to look into, but I've > been distracted by some background scanning problems (not specific to > brcmsmac). The channel mismatch could be related, but I do not have a clear picture yet. Possibly your tracepoints will help with that. Keep you posted. Gr. AvS ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: WARNING: at drivers/net/wireless/brcm80211/brcmsmac/main.c:7539 2013-01-02 14:08 ` Arend van Spriel @ 2013-01-02 15:09 ` Seth Forshee 2013-01-02 20:48 ` Arend van Spriel 0 siblings, 1 reply; 6+ messages in thread From: Seth Forshee @ 2013-01-02 15:09 UTC (permalink / raw) To: Arend van Spriel Cc: Linus Torvalds, Brett Rudley, Franky (Zhenhui) Lin, Hante Meuleman, John W. Linville, Linux Wireless List, brcm80211-dev-list On Wed, Jan 02, 2013 at 03:08:00PM +0100, Arend van Spriel wrote: > On 01/02/2013 02:50 PM, Seth Forshee wrote: > > On Wed, Jan 02, 2013 at 01:05:49PM +0100, Arend van Spriel wrote: > >> On 12/28/2012 07:07 AM, Linus Torvalds wrote: > >>> Ok, maybe somebody is interested in this.. I don't know what triggered > >>> it, but maybe the few lines around it give some clue. > >> > >> Hi Linus, > >> > >> I am interested (being paid for it kinda helps). The warning itself does > >> not necessarily have to be a problem, but the frameid mismatch between > >> tx status info and the related buffer taken from the DMA ring does. > >> Smells like a race condition, but I need to investigate that. > >> > >>> I think it's new to 3.8-rc1, because I haven't seen it before (well, > >>> I'm running current -git - v3.8.0-rc1-00035-g101e5c7470eb to be exact > >>> - but the networking changes since -rc1 are small and seem unrelated). > >>> But maybe it just happens under certain circumstances. > >> > >> We had a big contribution from Canonical (cc-ed Seth) in brcmsmac > >> itself. Not playing the blame game, but I suspect it has altered > >> circumstances making the real issue (that was already there) more likely > >> to happen. Hope that helps us nailing it down. > > > > I'm certain that both problems existed prior to 3.8-rc1. The warning > > itself has generated a fairly consistent trickle of bug reports for a > > while now. I haven't noticed any increased frequency of these messages; > > if anything I'd say I'm hitting the WARN_ON less often (though I've been > > doing a lot of testing under heavy load so my observations may not be > > typical). > > Hi Seth, > > Indeed the warning has been there for a while, but the fatal error > resulting in triggering a restart from mac80211 has popped up late in > the 3.7-rc cycles and seem to consistently fail on our smoketest as well. I looked at the errors again and realized I was interpreting some of your comments in the wrong context. I don't recall having seen the frameid != txh->TxFrameID problems in my testing. If you can give me a test case to reproduce then I'll take a look as well. Do you recall the exact -rc when it appeared? I can run a bisection if I can get it reproducing consistently. Seth ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: WARNING: at drivers/net/wireless/brcm80211/brcmsmac/main.c:7539 2013-01-02 15:09 ` Seth Forshee @ 2013-01-02 20:48 ` Arend van Spriel 0 siblings, 0 replies; 6+ messages in thread From: Arend van Spriel @ 2013-01-02 20:48 UTC (permalink / raw) To: Seth Forshee Cc: Linus Torvalds, Brett Rudley, Franky (Zhenhui) Lin, Hante Meuleman, John W. Linville, Linux Wireless List, brcm80211-dev-list On 01/02/2013 04:09 PM, Seth Forshee wrote: > On Wed, Jan 02, 2013 at 03:08:00PM +0100, Arend van Spriel wrote: >> On 01/02/2013 02:50 PM, Seth Forshee wrote: >>> On Wed, Jan 02, 2013 at 01:05:49PM +0100, Arend van Spriel wrote: >>>> On 12/28/2012 07:07 AM, Linus Torvalds wrote: >>>>> Ok, maybe somebody is interested in this.. I don't know what triggered >>>>> it, but maybe the few lines around it give some clue. >>>> >>>> Hi Linus, >>>> >>>> I am interested (being paid for it kinda helps). The warning itself does >>>> not necessarily have to be a problem, but the frameid mismatch between >>>> tx status info and the related buffer taken from the DMA ring does. >>>> Smells like a race condition, but I need to investigate that. >>>> >>>>> I think it's new to 3.8-rc1, because I haven't seen it before (well, >>>>> I'm running current -git - v3.8.0-rc1-00035-g101e5c7470eb to be exact >>>>> - but the networking changes since -rc1 are small and seem unrelated). >>>>> But maybe it just happens under certain circumstances. >>>> >>>> We had a big contribution from Canonical (cc-ed Seth) in brcmsmac >>>> itself. Not playing the blame game, but I suspect it has altered >>>> circumstances making the real issue (that was already there) more likely >>>> to happen. Hope that helps us nailing it down. >>> >>> I'm certain that both problems existed prior to 3.8-rc1. The warning >>> itself has generated a fairly consistent trickle of bug reports for a >>> while now. I haven't noticed any increased frequency of these messages; >>> if anything I'd say I'm hitting the WARN_ON less often (though I've been >>> doing a lot of testing under heavy load so my observations may not be >>> typical). >> >> Hi Seth, >> >> Indeed the warning has been there for a while, but the fatal error >> resulting in triggering a restart from mac80211 has popped up late in >> the 3.7-rc cycles and seem to consistently fail on our smoketest as well. > > I looked at the errors again and realized I was interpreting some of > your comments in the wrong context. I don't recall having seen the > frameid != txh->TxFrameID problems in my testing. If you can give me a > test case to reproduce then I'll take a look as well. I tried today and got dma_getnexttxp() return NULL pointer, which also results in a hardware restart. > Do you recall the exact -rc when it appeared? I can run a bisection if I > can get it reproducing consistently. Not sure. We did not upgrade the smoketests to every rc. So it only ran rc3 and rc6 although mac80211, cfg80211, and brcm80211 drivers were built and tested nightly from wireless-testing. Digging in my mailbox the last reliable smoketest seems to be around november 29th. Greetings, Arend ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-01-02 20:48 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-12-28 6:07 WARNING: at drivers/net/wireless/brcm80211/brcmsmac/main.c:7539 Linus Torvalds 2013-01-02 12:05 ` Arend van Spriel 2013-01-02 13:50 ` Seth Forshee 2013-01-02 14:08 ` Arend van Spriel 2013-01-02 15:09 ` Seth Forshee 2013-01-02 20:48 ` Arend van Spriel
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).