Re: [PATCHv3 2/2] mac80211: in AD-HOC mode wait for the AUTH response

[Nicolas Cavallari <Nicolas.Cavallari@lri.fr>]

On 07/01/2013 12:40, Antonio Quartulli wrote:
> On Wed, Jan 02, 2013 at 10:40:55AM +0100, Nicolas Cavallari wrote:
>> On 02/01/2013 07:32, Antonio Quartulli wrote:
>>> On Fri, Dec 28, 2012 at 03:51:08 +0100, Johannes Berg wrote:
>>>> Any chance we could converge on a single implementation here?
>>>
>>> Maybe yes :)
>>>
>>> I think that leaving the station not AUTHenticated and let userspace do so would
>>> be the best approach..but then we need a way to enable userspace to do it :)
>>
>> What would happen to old userspace that expect that to be done in the kernel ?
> 
> if the userspace did not register for auth frames, then authentication will be
> handled in the kernel (as I'm doing/changing now), while if the userspace
> registered for such frames, then the kernel will assume that the authentication
> will be handled by the userspace somehow and will not deal with it (but again,
> in this way we need a command to let userspace set the AUTHenticated flag on a
> station).

That means two implementations, not one.

And even with this current patch, old wpasupplicant starts 4 way handshake as soon as the
NEW_STA event is received, even if the station is not authenticated by the kernel. I
expect that some EAPOL frames will be dropped as a result.